jQuery .each() not working, any other ways?

Question

I want to do a foreach with each in jquery.

My function jquery have a call for another function showTauxPlafonds so i want for every a i have a call for this function to return a result with ajax.

For every <a> I want when I click I have a call for my function jquery :

$("a").each(function() {
  $(this).on("click", function() {
    showTauxPlafonds(urlTaux, $(this).attr('tauxPlafonds'));
  })
});


var showTauxPlafonds = function(url, tauxPlafonds) {
  if (tauxPlafonds != null)
    getAjaxedHtmlView(url, {
      tauxPlafonds: tauxPlafonds
    }, null, 'app_taux_plafonds_values');
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<a class="mdc-list-item" tauxPlafonds="PSS" data-toggle="tooltip" data-placement="top" title="Acceuil" style="cursor:pointer;width:350px">
Plafond sécurité sociale
</a>
<a class="mdc-list-item" data-toggle="tooltip" data-placement="top" title="Taux et plafonds" style="cursor:pointer;width:350px">
Smic
</a>

You can bind directly to the anchor, no need for the each - `$('a').on("click", function() {` although your code should work - what is your exact problem? Is it that the links are loading a new page so it looks as if your code is not hit? Or that `$(this)` is not what it seems in `showTauxPlafonds(urlTaux, $(this).attr('tauxPlafonds'));` — Pete, Oct 02 '18 at 09:36
I made you a proper snippet. Please add at least a dummy `getAjaxedHtmlView` — mplungjan, Oct 02 '18 at 09:37
this line - `showTauxPlafonds(urlTaux, $(this).attr('tauxPlafonds'));` - where is `urlTaux` defined? — treyBake, Oct 02 '18 at 09:38
Have a read of [mcve]. You should be able to generate some example code *without* the ajax call (ie with a dummy function) to demonstrate exactly *where* your code problem is (hint: given the code provided, it's probably not the `.each`) — freedomn-m, Oct 02 '18 at 09:39

mplungjan · Accepted Answer · 2018-10-02T11:26:40.017

0

I think you mean this, assuming url is the possible href of the link

There is no need for the showTauxPlafonds function since it is just testing the attribute which WILL be set unless you have tauxPlafonds="" in your code. Then you just test it in the selector:

var urlTaux = "someurl";
$("a[tauxPlafonds!='']").on("click", function() {
  getAjaxedHtmlView(urlTaux, { 
    tauxPlafonds: $(this).attr("tauxPlafonds")
  }, null, 'app_taux_plafonds_values')
});

I do suggest however you do data-tauxPlafonds="PSS" to not create new type of attributes

See jQuery: Select data attributes that aren't empty? for more example of testing an attribute

edited Oct 02 '18 at 11:26

answered Oct 02 '18 at 09:39

mplungjan

169,008
28
173
236

Another question where i put " urlTaux " like the code in the question ? – mecab1995 Oct 02 '18 at 09:57
I updated the answer - I cannot see where urlTaux comes from in your code – mplungjan Oct 02 '18 at 11:17
@mecab1995 my solution is more efficient – mplungjan Oct 02 '18 at 11:24
I have updated my code to ONLY select links that have non--empty tauxPlafonds attributes – mplungjan Oct 02 '18 at 11:27

score 0 · Answer 2 · answered Oct 02 '18 at 10:34

0

This method also solved my problem :

$("a[tauxPlafonds]").on("click", function () {
showTauxPlafonds(urlTaux, $(this).attr('tauxPlafonds'));
});

answered Oct 02 '18 at 10:34

mecab1995

163
1
2
11

Yes, but that is inefficient since all showTauxPlafonds does is test if the attr is empty which it is not since $("a[tauxPlafonds]") gets all As with the attribute – mplungjan Oct 02 '18 at 11:23

jQuery .each() not working, any other ways?

2 Answers2