Loop through txt file comma-separated and use as variable

Question

I have txt file separated by comma:

2012,wp_fronins.pdf
2013,test789.pdf
2014,ok09report.pdf

I'm trying to extract from the file each value and pass him to CURL command with a condition before. For example:

if $value1=2012 do 
curl "https://onlinesap.org/reports/$valu1/$value2

Any idea ?

see this https://stackoverflow.com/questions/1521462/looping-through-the-content-of-a-file-in-bash — , Oct 03 '18 at 07:15
No, they are not unique but repetitive. but the name of the pdf files is unique. — bugnet17, Oct 03 '18 at 07:26

score 1 · Accepted Answer · answered Oct 03 '18 at 08:12

1

Another way to achieve is to read the file directly and cut the rows to get the elements directly.

while read p; do
    value1=`echo $p | cut -d',' -f1`
    value2=`echo $p | cut -d',' -f2`
    if [ $value1 = "2012" ]; then
        curl "https://onlinesap.org/reports/$value1/$value2"
    fi
    # Add More conditional statements here for other value1
done < filename.txt

answered Oct 03 '18 at 08:12

Amit Bhardwaj

333
1
8

I guess this answer is better than mine – Robert Kock Oct 03 '18 at 08:26
or `while IFS=, read value1 value2; do` to avoid two sub shell calls and cut, however bash read is slow – Nahuel Fouilleul Oct 03 '18 at 10:20
note that quotes are useless around `2012` but should be used around `$value1`, regarding word splitting, with single square bracket `[` otherwise double square bracket could be used – Nahuel Fouilleul Oct 03 '18 at 10:26

Robert Kock · Answer 2 · 2018-10-03T08:21:49.603

0

Since the name of the pdf file (value2) is unique, you may try something like this:

#!/bin/bash

FILENAME=myFile.txt

cat $FILENAME | awk -F',' '{print $2}' | while read value2; do
  value1=`grep -w "$value2" $FILENAME | awk -F',' '{print $1}'` # watch the back-tick
  if [ $value1 = "2012" ]; then
    curl https://onlinesap.org/reports/$value1/$value2
  fi
done

Please notice that the whole file is scanned a second time for each line found.
In other words, its complexity is O(n^2)

edited Oct 03 '18 at 08:21

answered Oct 03 '18 at 07:54

Robert Kock

5,795
1
12
20

I think I have some problem with spaces in value2. The pdf reports sometimes contain spaces and then the script fails.. – bugnet17 Oct 03 '18 at 08:16
Put the `value2` within quotes when searching `value1`. I updated the answer – Robert Kock Oct 03 '18 at 08:22

Loop through txt file comma-separated and use as variable

2 Answers2