Return object in array with highest value of method

Question

I have an array of Pokemons. Pokemons have an abstract method vitesse(vitesse = speed in french), which change depending of the type of pokemon.

I also have a class TabPokemon which generate my array of pokemons. In this class I want to calculate the fastest pokemon.

This is my method :

public Pokemon plusRapide()
{
    Pokemon winner;
    double vitesse = 0.0;
    foreach(Pokemon p in tab)
    {
        if(p.vitesse()> vitesse)
        {
            vitesse = p.vitesse();
            winner = p;
        }

    }
    return winner;
}

It shows me an error on the return statement because it is assigned locally. How can I return the object Pokemon with the greatest speed value?

Well, what would you want to return if `tab` is empty, or if the `vitesse` value is negative for all elements? If you'd want to return `null`, then just assign `winner` as null initially. — Jon Skeet, Oct 04 '18 at 11:43
Unrelated to the question itself, I'd encourage you to start following .NET naming conventions as early as possible. — Jon Skeet, Oct 04 '18 at 11:43
This could by done using linq in a single line of code - `return tab.OrderBy(p => p.vitesse()).FirstOrDefault();` — Zohar Peled, Oct 04 '18 at 11:45
@ZoharPeled: Or without sorting by using MoreLINQ's `MaxBy`. — Jon Skeet, Oct 04 '18 at 11:45
@JonSkeet I guess I really should download and investigate that MoreLINQ library... It's popping out everywhere lately :-) — Zohar Peled, Oct 04 '18 at 11:46

score 3 · Accepted Answer · answered Oct 04 '18 at 11:43

3

Initialize the Pokemon object by Pokemon winner = null; on the first line of the method.

answered Oct 04 '18 at 11:43

kaffekopp

2,551
6
13

Return object in array with highest value of method

1 Answers1