I added download function on my webview app but when i press download button app crashes

Question

public class MainActivity extends AppCompatActivity {
private WebView webView;
String url = "https://svidzdownloader.com/";
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    webView = (WebView)findViewById(R.id.webview);
    webView.setWebViewClient(new WebViewClient());
    webView.loadUrl(url);
    WebSettings webSettings = webView.getSettings();

    webSettings.setJavaScriptEnabled(true);
    webView.setDownloadListener(new DownloadListener() {
        @Override
     public void onDownloadStart(String s, String s1, String s2, String s3, 
     long l) {
            DownloadManager.Request request = new DownloadManager.Request(Uri.parse(url));
            request.allowScanningByMediaScanner();
            request.setNotificationVisibility(DownloadManager.Request.VISIBILITY_VISIBLE_NOTIFY_COMPLETED);
            request.setDestinationInExternalPublicDir(Environment.DIRECTORY_DOWNLOADS,"Download");
            DownloadManager dm = (DownloadManager)getSystemService(DOWNLOAD_SERVICE);
            dm.enqueue(request);
        }
    });



}

I have made a webview app and i want to download videos from my webview app and i have add the download function code above but this code is not working when i press download button my app crashes

What error do you see in the logcat? Please add the logcat to your question too. — ʍѳђઽ૯ท, Oct 07 '18 at 12:37
java.lang.SecurityException: No permission to write to /storage/emulated/0/Download/Download: Neither user 10143 nor current process has android.permission.WRITE_EXTERNAL_STORAGE. — Ahmed Shahryar Shery, Oct 07 '18 at 12:42
this my logcat and i have written permission on my manifest write external srorage — Ahmed Shahryar Shery, Oct 07 '18 at 12:43
even i have add perimission in menifest this code dosent work and i have seen this code on stack over flow — Ahmed Shahryar Shery, Oct 07 '18 at 12:45

ʍѳђઽ૯ท · Accepted Answer · 2018-10-07T13:32:49.283

No permission to write to /storage/emulated/0/Download/Download: Neither user 10143 nor current process has android.permission.WRITE_EXTERNAL_STORAGE

Go to AndroidManifest.xml and above of <application tag add:

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

It seems like you'll need runtime permission too. Add the following codes inside your onDownloadStart for example:

@Override
public void onDownloadStart(String s, String s1, String s2, String s3, 
             long l) {

                   if (ActivityCompat.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE)
                    != PackageManager.PERMISSION_GRANTED) {
                // permission has not been granted.
                 // Request for the permission like adding a function which will do that

                  requestPermission(); // a function to request permissions

            } else {

               // Permission granted!! do your stuff here

                 DownloadManager.Request request = new DownloadManager.Request(Uri.parse(url));
                 request.allowScanningByMediaScanner();

                 request.setNotificationVisibility(DownloadManager.Request.VISIBILITY_VISIBLE_NOTIFY_COMPLETED);
                 request.setDestinationInExternalPublicDir (Environment.DIRECTORY_DOWNLOADS,"Download");
                 DownloadManager dm = (DownloadManager)getSystemService(DOWNLOAD_SERVICE);
                 dm.enqueue(request);


          }
 });

Function to request permission:

private void requestPermission() {
        Log.i(TAG, "permission has NOT been granted. Requesting permission.");
            private static final int REQUEST_EXTERNAL = 0;


        if (ActivityCompat.shouldShowRequestPermissionRationale(this,
                Manifest.permission.WRITE_EXTERNAL_STORAGE)) {
            // Provide an additional rationale to the user if the permission was not granted
            // and the user would benefit from additional context for the use of the permission.
            // For example if the user has previously denied the permission.
            Log.i(TAG,
                    "Displaying permission rationale to provide additional context.");
            Snackbar.make(mLayout, R.string.permission_camera_rationale,
                    Snackbar.LENGTH_INDEFINITE)
                    .setAction(R.string.ok, new View.OnClickListener() {
                        @Override
                        public void onClick(View view) {
                            ActivityCompat.requestPermissions(MainActivity.this,
                                    new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE},
                                    REQUEST_EXTERNAL);
                        }
                    })
                    .show();
        } else {

            // permission has not been granted yet. Request it directly.
            ActivityCompat.requestPermissions(this, new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE},
                    REQUEST_EXTERNAL);
        }

    }

Check this link: https://developer.android.com/training/permissions/requesting

And this: Neither user 10102 nor current process has android.permission.READ_PHONE_STATE

You'll need runtime permission too. I've updated my answer. please have a look — ʍѳђઽ૯ท, Oct 07 '18 at 12:49
these two answer where i will have add these answer in my code i asking this — Ahmed Shahryar Shery, Oct 07 '18 at 12:55
Add them inside your `Activity`. If you read [this link](https://developer.android.com/training/permissions/requesting), everything will be clear to understand. — ʍѳђઽ૯ท, Oct 07 '18 at 12:56
please the answer you have wrote add this answer into my code above — Ahmed Shahryar Shery, Oct 07 '18 at 13:03
There is a good sample from google [in here](https://github.com/googlesamples/android-RuntimePermissions/blob/master/Application/src/main/java/com/example/android/system/runtimepermissions/MainActivity.java) which you can use. Use the first line of codes inside your `onDownloadStart` then first check if user accepted the permission, then do your stuff. Use the link I've provided. — ʍѳђઽ૯ท, Oct 07 '18 at 13:08
just please add answer is my default code so i can understant in the link i cannot understand — Ahmed Shahryar Shery, Oct 07 '18 at 13:15
Please check the updated answer. However, this is not how Stack Overflow works. We don't code for users. We help them instead ;) I've added explanation in the codes as comments. — ʍѳђઽ૯ท, Oct 07 '18 at 13:28
ok after we add this code we have to initilaize the mehtod on oncreate?? — Ahmed Shahryar Shery, Oct 07 '18 at 13:32
No. You'll just need `implements ActivityCompat.OnRequestPermissionsResultCallback` in your Activity. Check this example: https://github.com/googlesamples/android-RuntimePermissions/blob/master/Application/src/main/java/com/example/android/system/runtimepermissions/MainActivity.java — ʍѳђઽ૯ท, Oct 07 '18 at 13:33
Please ask this (with added codes inside) in another question. So that we can help you better. — ʍѳђઽ૯ท, Oct 07 '18 at 20:48

I added download function on my webview app but when i press download button app crashes

1 Answers1