Return string in http get request Angular 6

Question

I have some problem returning a string from my request.

getTest(id: string): string {
  let foo: string = '';
  this.service.testProfile(id).subscribe(
    response => {
      foo = response.body.foo;
    },
    error => {
      console.log(error);
    }
  )
  return foo;
}

I want to init foo to my response. foo and then just to return new value of foo. Everything work but there is no result, any idea what I'm doing wrong?

Thank

`foo= response.body.foo;` is executed AFTER the return statement. That's why is always an empty string — Jacopo Sciampi, Oct 08 '18 at 11:59
So why you are returning? Just assign in a property of your component. When component value will change your value will reflect on your DOM. Observables are asynchronous so if you will return then it will return a empty string. — Sandip Jaiswal, Oct 08 '18 at 12:04
Possible duplicate of [How do I return the response from an asynchronous call?](https://stackoverflow.com/questions/14220321/how-do-i-return-the-response-from-an-asynchronous-call) — lealceldeiro, Oct 08 '18 at 12:04
Use this implementation instead: `getTest(id: string): Observable { return this.service.testProfile(id).pipe(map(response => response.body.foo)); }` — SiddAjmera, Oct 08 '18 at 12:06
can you please add the code snippet for this.service.testProfile ? That is the implementation. — Sandeep Kamath, Oct 08 '18 at 12:12

score 1 · Answer 1 · answered Oct 09 '18 at 08:56

1

I resolved with Promise

getTest(id: string): Promise<any>  {
 return new Promise((resolve,reject) => {
  this.service.testProfile(id).subscribe(
   response => {
    foo = response.body.foo;
   },
   error => {
    console.log(error);
   }
   )
  }
  )
 }

Thanks everybody !

answered Oct 09 '18 at 08:56

mrkibzk

227
4
17

Where does the variable "foo" come from in your code above? – Janik Spies Jul 05 '20 at 13:19

score 0 · Answer 2 · answered Oct 08 '18 at 12:07

0

You return a string which must still be filled (and thus is empty) as the async code to do so hasn't completed yet by the time you return. What you should return is an observable and emit the right string on it in the subscribe(...) call.

answered Oct 08 '18 at 12:07

Bartios

99
5

score 0 · Answer 3 · answered Oct 08 '18 at 12:09

0

Change your code like this and try..

getTest(id: string): string {
  this.service.testProfile(id).subscribe(
    response =>  response.body.foo,
    error => {
      console.log(error);
      return '';
    }
  )
}

answered Oct 08 '18 at 12:09

Karthick Srinivasan

93
6

Return string in http get request Angular 6

3 Answers3