When I returned to the previous page, my app crashed

Question

I have an app in which I can open camera and take a photo and to save gallery. When I click on button to open camera its works. If I click the back button on the phone without taking a photo, my application is stopped. How can I solve this problem ?

    Button camera = (Button) findViewById(R.id.camer);
    camera.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View arg0) {
            Intent cameraIntent = new Intent(android.provider.MediaStore.ACTION_IMAGE_CAPTURE);
            startActivityForResult(cameraIntent, CAMERA_PIC_REQUEST);


        }
    });

    send.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {

            Intent i = new Intent(Intent.ACTION_SEND);


            //Log.d("URI@!@#!#!@##!", Uri.fromFile(pic).toString() + "   " + pic.exists());
            if (pic != null) {
                i.putExtra(Intent.EXTRA_STREAM, Uri.fromFile(pic));
            }

            i.setType("image/jpg");

            startActivity(Intent.createChooser(i, "Share you on the jobing"));
        }
    });


}

protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    if (requestCode == CAMERA_PIC_REQUEST) {
        thumbnail = (Bitmap) data.getExtras().get("data");
        image = (ImageView) findViewById(R.id.imageToUpload);

        image.setImageBitmap(thumbnail);


        try {
            File root = Environment.getDataDirectory();
            if (root.canWrite()) {
                pic = new File(root, "pic.jpg");
                FileOutputStream out = new FileOutputStream(pic);
                thumbnail.compress(CompressFormat.JPEG, 100, out);
                out.flush();
                out.close();
            }

        } catch (IOException e) {
            Log.e("BROKEN", "Could not write file " + e.getMessage());
        }

    }

}

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Bundle android.content.Intent.getExtras()' on a null object reference

Please post the logcat error otherwise no one will be able to answer your question — debo.stackoverflow, Oct 08 '18 at 12:05
So use the if condition that if data is null, will not save any bitmap. Without taking any photo, it is a given that data will return null — debo.stackoverflow, Oct 08 '18 at 12:12

Santhosh Joseph · Accepted Answer · 2018-10-08T12:19:36.767

Its because your data is null

Try this way :

protected void onActivityResult(int requestCode, int resultCode, Intent data) {
 if(requestCode == CAMERA_PIC_REQUEST){
   if (resultCode == RESULT_OK) {
       thumbnail = (Bitmap) data.getExtras().get("data");
       image = (ImageView) findViewById(R.id.imageToUpload);

       image.setImageBitmap(thumbnail);


       try {
           File root = Environment.getDataDirectory();
             if (root.canWrite()) {
                pic = new File(root, "pic.jpg");
                FileOutputStream out = new FileOutputStream(pic);
                thumbnail.compress(CompressFormat.JPEG, 100, out);
                out.flush();
                out.close();
            }

         } catch (IOException e) {
             Log.e("BROKEN", "Could not write file " + e.getMessage());
         }

      }
   }

}

More reference : Getting a Result from an Activity

Welcome. Happy coding :) – Santhosh Joseph Oct 08 '18 at 12:26 — Santhosh Joseph, Oct 08 '18 at 12:26

score 0 · Answer 2 · answered Oct 08 '18 at 12:17

Try this

 protected void onActivityResult(int requestCode, int resultCode, Intent data) {
        if(resultCode == RESULT_OK) {

       if (requestCode == CAMERA_PIC_REQUEST) {
                    Bitmap thumbnail = (Bitmap)data.getExtras().get("data");

                }

   }
        if (resultCode == RESULT_CANCELED) {
            return;
        }
        }


            }

When I returned to the previous page, my app crashed

2 Answers2