javascript, problem with printing largest number entered

Question

The program is required to terminate if 0 is entered, otherwise it will keep going. If 0 is entered i need to print to the console the largest value entered. Need some help fixing this code. it doesn't always print the largest number entered. Sometimes it does.

     var number = 1;
     var largest = 0;

 do {
       number = prompt("Enter a number other than 0 and will tell you the largest");
       if(number >= largest) {    //If largest is small, set current number 
       as largest
       largest = number;
       }
    }  while (number > 0);
       console.log("The largest number is " + largest);

`as largest` on its own line will cause a `SyntaxError`. Check your console. — CertainPerformance, Oct 11 '18 at 04:14
Cast to an actual number first, else you're comparing *strings*. (your `number` is not a number) — CertainPerformance, Oct 11 '18 at 04:16
do i need to parseInt(number) before i plug it into the if statement? — user7123308, Oct 11 '18 at 04:17

Ehsan · Answer 1 · 2018-10-11T04:24:33.127

0

You must convert value of prompt to number.

var number = 1;
var largest = 0;

do {

  number = prompt("Enter a number other than 0 and will tell you the largest");

  if (parseFloat(number) >= largest)
    largest = number;
  
  } while (number > 0);

console.log("The largest number is " + largest);

edited Oct 11 '18 at 04:24

answered Oct 11 '18 at 04:19

Ehsan

12,655
3
25
44

so does storing a value from prompt always turn it into a string? – user7123308 Oct 11 '18 at 04:21
yes,you must convert to number – Ehsan Oct 11 '18 at 04:22

javascript, problem with printing largest number entered

1 Answers1