NewsAPI C# library runs on console, hangs on winforms

Question

I ran the example given at the web site under Visual Studio 2017 Community Edition and it worked fine. However, when I attempted to run it on a winforms library, it hung, even when given the exact same term:

Console Version

static void Main(string[] args)
{
    var newsApiClient = new NewsApiClient("KeyRedacted");
    var articlesResponse = newsApiClient.GetEverything(new EverythingRequest
    {
        Q = "Apple",
        SortBy = SortBys.Popularity,
        Language = Languages.EN,
        From = new DateTime(2018, 10, 16)
    });
    if (articlesResponse.Status == Statuses.Ok)
    {

    //code here

Winforms Version

private void btnSearch_Click(object sender, EventArgs e)
{
    var newsApiClient = new NewsApiClient("keyredacted");
    var articleResponse = newsApiClient.GetEverything(new EverythingRequest
    {
        Q = "Apple",
        SortBy = SortBys.Popularity,
        Language = Languages.EN,
        From = new DateTime(2018, 10, 16)
    });  //this is where it hangs

    if (articleResponse.Status == Statuses.Ok)
    {

is the `NewsApiClient` constructor case sensitive? `KeyRedacted` vs `keyredacted` — A Friend, Oct 18 '18 at 16:29
Does 'NewsApiClient' use any async code - especially: Is 'GetEverything' calling any async code? — Poul Bak, Oct 18 '18 at 16:30
This is the URL for newsapi https://github.com/News-API-gh/News-API-csharp — John Meyer, Oct 18 '18 at 16:57

score 1 · Accepted Answer · answered Oct 18 '18 at 16:47

Assuming that you're using this client, the method you're calling uses a Task.Result which can cause a deadlock. Seems reasonable, since the code/signature and examples match.

I would rewrite your code like this for WinForms:

private async void btnSearch_Click(object sender, EventArgs e)
{
    var newsApiClient = new NewsApiClient("keyredacted");
    var articleResponse = await newsApiClient.GetEverythingAsync(new EverythingRequest
    ...

If you are deadset on not using the async methods in your code you could try running it inside of a Task.Run(() => /* stuff */);

See also: https://blogs.msdn.microsoft.com/pfxteam/2012/04/13/should-i-expose-synchronous-wrappers-for-asynchronous-methods/

NewsAPI C# library runs on console, hangs on winforms

1 Answers1