Async/await in Web.API 2 Controllers Action

Asked Oct 21 '18 at 18:09

Active Oct 21 '18 at 18:09

Viewed 41 times

I have controller with actions like below:

public async Task<IHttpActionResult> GetData()
{
    var resultSet = await Task.Run(()=>{Repository.GetRecords();});
    if(resultSet==null)
    {
        return ErrorResponse(){Message = Repository.LastErrorMessage};
    }
    return Ok(resultSet);
}

Repository.GetData is using ODBC driver for getting data from Database. Is this pattern ok for WEB.API Action or it will harm the performance by creating separate Task for getting Data?

asked Oct 21 '18 at 18:09

Samvel Petrosov

7,580
2
22
46

Don't use `Task.Run` for I/O operations. Use the proper asynchronous methods in `GetRecords()` – Camilo Terevinto Oct 21 '18 at 18:17
@CamiloTerevinto Repository is not using any Framework and there are not any asynchronous methods. So it would be better to take async/await to Repository? – Samvel Petrosov Oct 21 '18 at 18:20
If there are no asynchronous method then don't use asynchronous calls. Creating a thread to wait on an I/O operation is a waste. – Camilo Terevinto Oct 21 '18 at 18:23
@CamiloTerevinto ok, thank you. – Samvel Petrosov Oct 21 '18 at 18:23

Async/await in Web.API 2 Controllers Action

0 Answers0