Room Dao Null Pointer exception

Question

I am getting null pointer exception on the abstract Dao method which we create in room database class. While few sample projects i referred does the same thing but its working. I do not understand when and where this instance is initialized in others projects. Here is my main activity code below:

Mainactivity:

package com.example.datta.roomtest;

import android.os.AsyncTask;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.util.Log;
import android.view.View;
import android.webkit.WebView;
import android.widget.Button;
import android.widget.EditText;
import android.widget.TextView;

import com.example.datta.roomtest.Dao.PlayerDao;
import com.example.datta.roomtest.Database.AppDatabase;
import com.example.datta.roomtest.Entity.Player;

import java.util.List;

public class MainActivity extends AppCompatActivity {

    AppDatabase appDatabase;
    TextView tvName,tvRole;
    EditText etName,etRole;
    Button btnGet,btnPut;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        appDatabase= AppDatabase.getInstance(this);
        init();

        setListeners();

    }

    private void init() {

    tvName=(TextView)findViewById(R.id.tvPlayername);
    tvRole=(TextView)findViewById(R.id.tvPlayerRole);
    etName=(EditText)findViewById(R.id.etName);
    etRole=(EditText)findViewById(R.id.etRole);
    btnGet=(Button)findViewById(R.id.btnGetData);
    btnPut=(Button)findViewById(R.id.btnPutData);
    }
    private void setListeners() {

        btnGet.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {


                new DbAsync().execute("get");
            }
        });

        btnPut.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {



                new DbAsync().execute("put");
            }
        });

    }


     class DbAsync extends AsyncTask<String,Void,Void>{


        @Override
        protected Void doInBackground(String... strings) {


            Log.i("MainTag",strings[0]);


            if(strings[0].equals("get")){

                PlayerDao playerDao = appDatabase.getPlayerDao();

              List<Player>playerList=playerDao.getAllPlayers();
                for (Player player:playerList){

                    tvName.setText(player.getName());
                    tvRole.setText(player.getRole());

                }


            }
            if(strings[0].equals("put")){

                PlayerDao playerDao=appDatabase.getPlayerDao();
                playerDao.insertAll(new Player("Ronaldo","Striker"));
                playerDao.insertAll(new Player("Messi","Winger"));

            }

            return null;
        }

        @Override
        protected void onPostExecute(Void aVoid) {
            super.onPostExecute(aVoid);
        }
    }


}

Here is my Appdatabase:

package com.example.datta.roomtest.Database;

import android.arch.persistence.room.Database;
import android.arch.persistence.room.Room;
import android.arch.persistence.room.RoomDatabase;
import android.content.Context;

import com.example.datta.roomtest.Dao.PlayerDao;
import com.example.datta.roomtest.Entity.Player;

@Database(entities = {Player.class},version = 1)
public abstract class AppDatabase extends RoomDatabase {

private static AppDatabase appDatabase;


public static AppDatabase getInstance(Context context){

    if(appDatabase!=null){

        appDatabase = Room.databaseBuilder(context.getApplicationContext(),
                AppDatabase.class, "database-name").build();
        }

    return appDatabase;

}

  public abstract PlayerDao getPlayerDao();


}

I am getting this null pointer error when this getPlayerDao() method is called:

 Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'com.example.datta.roomtest.Dao.PlayerDao com.example.datta.roomtest.Database.AppDatabase.getPlayerDao()' on a null object reference
        at com.example.datta.roomtest.MainActivity$DbAsync.doInBackground(MainActivity.java:97)
        at com.example.datta.roomtest.MainActivity$DbAsync.doInBackground(MainActivity.java:71)
        at android.os.AsyncTask$2.call(AsyncTask.java:316)

Its not Duplicate, i thought problem is in background of room. — Maximus, Oct 23 '18 at 08:49
it is a duplicate. the problem is (as it is in the other ticket) you try to access instance members on a non-instantiated object. just like in that code, the task is to debug and to check where it should be instantiated correctly. That your logical error was a wrong conditional statement, doesn't make this any less a duplicate — Stultuske, Oct 23 '18 at 09:15

score 3 · Accepted Answer · answered Oct 23 '18 at 07:58

3

getInstance() always return null due to wrong test:

public static AppDatabase getInstance(Context context){
    if(appDatabase!=null){ // <= ERROR HERE, should be == null
        appDatabase = Room.databaseBuilder(context.getApplicationContext(),
                AppDatabase.class, "database-name").build();
    }
    return appDatabase;

}

answered Oct 23 '18 at 07:58

Benoit

5,118
2
24
43

Oh thank you. I copied that from some sample project and didnt check it. Was quite simple. I thought the problem is in background working of room. – Maximus Oct 23 '18 at 08:49

Room Dao Null Pointer exception

1 Answers1

Linked