C# WinForm doesn't close.

Question

I have an application with one main form. In the form I have one object objC of class C. The form gets from objC my control and puts it into panel. The form interacts with objC through methods calling and subscribing to objC’s events.

When I try to close the form by clicking on [X] button or by calling this.Close(), form isn’t closing. It calls handler of FormClosing. In the handler, I call objC.Dispose(). I checked, there are no exceptions generated. In objC.Dispose() I unsubscribe from all form’s event handlers. And I removed my control from panel with this code:

splitContainerMain.Panel2.SuspendLayout();
{
    splitContainerMain.Panel2.Controls.Clear();
}
splitContainerMain.Panel2.ResumeLayout();

But it just won’t close. I can try to close as many times as I will, FormClosing event will be repeated, but FormClose will be never generated.

This bug is not reproduced when I don't create a control and add it to the panel. What have I done wrong?

score 3 · Accepted Answer · answered Mar 15 '11 at 22:46

There are few explanations for this. But one, you might have a Validating event handler that is canceling the validation. This will also cancel OnFormClosing. Fix:

    void Form1_FormClosing(object sender, FormClosingEventArgs e) {
        e.Cancel = false;
    }

Btw, there is no point in calling Suspend/ResumeLayout, there is no layout done at form closing time. And calling Controls.Clear() does not actually dispose the controls. Rather nasty behavior that trips up a lot of programmers. Best thing to do is to do nothing, parent controls automatically dispose their children controls. And there is no point in unsubscribing events either, the form object and the objC object only reference each other, no other references exist. The garbage collector knows how to handle that.

Thank you! Setting e.Cancel = false; solved my problem. Sadly, I have no time to investigate, who is setting this e.Cancel to true. And I have no Validation handler. I know, that Control.Clear is not disposing controls. In my code it only removes my control from panel and actual disposing is made by objC. — pashkoff, Mar 16 '11 at 23:08

score 0 · Answer 2 · edited May 23 '17 at 11:47

This question seems to be releated to : Cleaning objects off a form, Where and When? which provides two good alternatives for dealing with your object.

Either dispose of it by implementing the Form's Dispose method or
Simply ensure that the control is added to the System.ComponentModel.IContainer components property of the form. This will ensure that it's dispose method will be called when the form is disposed.

C# WinForm doesn't close.

2 Answers2

Linked