Class Employee ID count c++

Question

I'm editing it, now ok i apply an empty constructor and my code worked but this way:

Name1 SName1 1000 0.2 100 Name2 SName2 1000 0.3 750

This code normally works perfectly and my teacher especially wants us to use "this->" and "*this" so here's my code: my .h file

#ifndef COMEMPLOYEE_H
#define COMEMPLOYEE_H
#include <string>
using namespace std;
class ComEmployee
{
protected:
string firstName;
string lastName;
static int ID;
double grossSale;
double comRate;

public:
ComEmployee();
ComEmployee(string, string, double, double);
ComEmployee& setfirstName(string);
ComEmployee& setlastName(string);
ComEmployee& setgrossSale(double);
ComEmployee& setcomRate(double);
string getfirstName();
string getlastName();
double getgrossSale();
double getcomRate();
int getID() const;
double calCom() const;
void Display() const;

};


#endif

my .cpp file

#include "ComEmployee.h"
#include <iostream>

using namespace std;

int ComEmployee::ID = 1000;
ComEmployee::ComEmployee(){}

ComEmployee::ComEmployee(string name, string lname, double gs, double comr)
{
this->firstName = name;
this->lastName = lname;
this->grossSale = gs;
this->comRate = comr;
++ID;
}

int ComEmployee::getID() const
{
return ID;
}

ComEmployee & ComEmployee::setfirstName(string name)
{
firstName = name;
return *this;
}

ComEmployee & ComEmployee::setlastName(string lname)
{
lastName = lname;
return *this;
}

ComEmployee & ComEmployee::setgrossSale(double gs)
{
grossSale = gs;
return *this;
}

ComEmployee & ComEmployee::setcomRate(double comr)
{
comRate = comr;
return *this;
}

string ComEmployee::getfirstName()
{
return firstName;
}

string ComEmployee::getlastName()
{
return lastName;
}

double ComEmployee::getgrossSale()
{
return grossSale;
}

double ComEmployee::getcomRate()
{
return comRate;
}


double ComEmployee::calCom() const
{
return grossSale*comRate;
}

void ComEmployee::Display() const
{
cout << firstName << " "  << " " << getID() << " " << comRate << " " << calCom() << endl;
}

here's my main.cpp file

#include <iostream>
#include "ComEmployee.h"

using namespace std;

int main()
{
ComEmployee employee, employee2;
employee.setfirstName("Name1").setlastName("SName1").setgrossSale(500).setcomRate(0.2).Display();
employee2.setfirstName("Name2").setlastName("SName2").setgrossSale(2500).setcomRate(0.3).Display();

system("pause");

}

I want my output as:

Name1 SName1 1001... Name2 SName2 1002...

you need to implement all the methods you have declared – Alan Birtles Nov 15 '18 at 08:11 — Alan Birtles, Nov 15 '18 at 08:11

snake_style · Answer 1 · 2018-11-15T09:16:45.343

0

Add some int variable to your class definition:

int m_ID;

Then, you need to emplement a default constructor in cpp-file:

// cpp
ComEmployee::ComEmployee()
{
    m_ID = ID++;
}

And modify your GetID function:

int ComEmployee::GetID() const
{
    return m_ID;
}

edited Nov 15 '18 at 09:16

answered Nov 15 '18 at 08:13

snake_style

1,139
7
16

ok but now it doesn't count, 1000 and 1000 again. – lala olala Nov 15 '18 at 08:15
ComEmployee::ComEmployee() { ID++; } – snake_style Nov 15 '18 at 08:18
now both 1002, it worked but i need to have it as 1001, 1002 – lala olala Nov 15 '18 at 08:22
Add new variable _int m_ID_, in class declaration. Then change _ComEmployee::ComEmployee() { m_ID = ID++; } int ComEmployee::getID() const { return m_ID; }_ – snake_style Nov 15 '18 at 08:38
I tried that before, now output both: -858993460 – lala olala Nov 15 '18 at 08:46
@lalaolala are you sure? ComEmployee::ComEmployee() { **m_ID = ID++;** } and int ComEmployee::getID() const { return **m_ID**; } – snake_style Nov 15 '18 at 08:48
sorry i didn't rewrite it on the empty constructor now it worked thank you so much! – lala olala Nov 15 '18 at 08:54
@snake_style All information, that answers the question must be in the answer, and not in the comments. And, because .cpp file contains the same definition of default constructor (`ComEmployee::ComEmployee(){}`), as your answer suggests - this answer doesn't answer the question.. – Algirdas Preidžius Nov 15 '18 at 08:57
@AlgirdasPreidžius the question has changed in the discuss process... There was no implementation of default ctor – snake_style Nov 15 '18 at 09:19

score 0 · Answer 2 · answered Nov 15 '18 at 09:07

You have to change your design a bit. As ID is employee ID, it cannot be a static variable. A static variable belongs to the class rather than to particular instance of the class.
Define ID as a normal member of the class.

You can use a new static variable CurrentID instead to keep track of the employees.
After defining it like below,

int ComEmployee::CurrentID = 1000;

In the default and non-default constructors, do the following:

this->ID = CurrentID++;

Class Employee ID count c++

2 Answers2