No Update done with PDO php

Question

I have problem without any error in my code that update row ..

if(!isset($error)){

    try {
        $sql = "UPDATE `invoice` SET `client`='".$client."', `company`='".$company."' , `clientemail`='".$clientemail."' , `mobailclient`='".$mobailclient."' , `startdate`='".$startdate."' , `enddate`='".$enddate."' WHERE `id` ='".$id."'";

        $count = $db->exec($sql);


        //redirect to invoice page
        header('Location: invoice.php');
        exit;

    //else catch the exception and show the error.
    } catch(PDOException $e) {
        $error[] = $e->getMessage();
    }

}

This is my code , i try to get variable $sql and go to mysql phpmyadmin and its work good ,, but in file not work and i dont get any error

==== Update ====

i try this and not work

    try {
        $sql = 'UPDATE invoice SET client = :client,  company = :company,  clientemail = :clientemail,  mobailclient = :mobailclient,  startdate = :startdate,  enddate = :enddate WHERE id = :id';

        $statement = $db->prepare($sql);
        $statement->bindParam(":client", $client);
        $statement->bindParam(":company", $company); 
        $statement->bindParam(":clientemail", $clientemail); 
        $statement->bindParam(":mobailclient", $mobailclient); 
        $statement->bindParam(":startdate", $startdate); 
        $statement->bindParam(":enddate", $enddate); 
        $statement->bindParam(":id", intval($_GET['id']) ); 
        $statement->execute();
        if($statement->rowCount() > 0) // will return 1 if any row is updated
        {
            echo "<script>alert('".$statement->rowCount()."')</script>";
        }
        else
        {
            echo "<script>alert('No record updated')</script>";
        }

yes i enter ,, i put redirect to invoice page, and its redirect — , Nov 15 '18 at 08:36

Sajjad Ali · Accepted Answer · 2018-11-15T12:21:16.163

2

Your query is opened for SQL Injection. You should use parameterized query which provide a kind of protection against SQL injection but will not provide 100% of protection. Kindly visit this Post for more details.

Try the following code by replacing table and column names.

$client = "my name";
$company = "my-company";
$id= 2;//make sure your table has a record with that specific id
$sql = 'UPDATE invoice SET client = :client,  company = :company WHERE id = :id'; // here i am updating only two columns
//You can add more column that you want to upate like ColumnName = :ParameterIdentifier
//Where ParameterIdentifier Is the name of parameter used in bindParam as in my example company  
$statement = $db->prepare($sql);
$statement->bindParam("client", $client); //Binding parameter for client
$statement->bindParam("company", $company); //Binding parameter for company 
$statement->bindParam("id", $id); 
$statement->execute();
if($statement->rowCount() > 0) // will return 1 if any row is updated
{
    echo "Record updated successfully";
}
else
{
    echo "No record updated";
}

edited Nov 15 '18 at 12:21

answered Nov 15 '18 at 11:18

Sajjad Ali

304
3
12

what you mean for `$name` in `$statement->bindParam("LastName", $name);` – Nov 15 '18 at 12:07
In my given sample I have set dummy variables. Just to provide you a hint. You can change according to your need – Sajjad Ali Nov 15 '18 at 12:17
I have edited my answer and make a query that will update only two columns. – Sajjad Ali Nov 15 '18 at 12:22
Do not pass values directly to bindParam() method – Sajjad Ali Nov 15 '18 at 12:24
first assigned id to a variable then passed that variable to bindParam() method Like: $id = intval($_GET['id']); $statement->bindParam(":id",$id ); – Sajjad Ali Nov 15 '18 at 12:26
Glad to help you – Sajjad Ali Nov 15 '18 at 12:46

No Update done with PDO php

1 Answers1