While loop over numbers doesn't seem to be working

Question

I am new to python and I am trying run this piece of code, however, the while loop doesn't seem to be working. Any ideas?

def whilelooper(loop):
    i = 0
    numbers = []


    while i < loop:
        print "At the top i is %d" %i
        numbers.append(i)

        i += 1
        print "numbers now:",numbers
        print "At the bottom i is %d" %i

    print "the numbers:",

    for num in numbers:
        print num


print "Enter a number for loop"
b = raw_input(">")

whilelooper(b)

What do you hope for the code to do and what actual behavior do you observe? Also, please [edit] the code to fix the indentation. — tripleee, Nov 16 '18 at 09:41
`raw_input` returns a string... you need `whilelooper(int(b))` — OneCricketeer, Nov 16 '18 at 09:44
By the way, `for i in range(loop)` would be "safer" than a while loop — OneCricketeer, Nov 16 '18 at 09:45
@cricket_007 made the change... it still seems to be going on beyond the entered value. I needed the range to be set according to the user's input — Priyanka Yadav, Nov 16 '18 at 09:49
What do you mean "seems"? Either it is, or is not. Please [edit] the quesiton with the updated code and what is being printed (as text, please, not an image) — OneCricketeer, Nov 16 '18 at 09:50
@cricket_007 Thank you soo much. Adding "loop = int(loop)" solved the problem — Priyanka Yadav, Nov 16 '18 at 09:52
You may use the checkmark next to the answer below to accept it — OneCricketeer, Nov 16 '18 at 09:53

score 2 · Accepted Answer · answered Nov 16 '18 at 09:41

2

Your input is inputted as a string type, but the comparator

while i < loop:

is expecting both i and loop to be of type int (for integer), in order to be able to compare them.

You can fix this by casting loop to an int:

def whilelooper(loop):
    i = 0
    numbers = []
    loop = int(loop)
    ...

answered Nov 16 '18 at 09:41

Ben Jones

555
6
22

1

Or `whilelooper(int(b))` – OneCricketeer Nov 16 '18 at 09:44
Better to do it inside the function, because it's always going to want to be an int for the function to work – Ben Jones Nov 16 '18 at 09:47

While loop over numbers doesn't seem to be working

1 Answers1