Running ping command in the shell from app

Question

I have found source code that gives an opportunity to run a shell command from the app, and, as I can understand, returns a string with the executed command result:

http://code.google.com/p/netmeterled/source/browse/trunk/src/com/britoso/cpustatusled/utilclasses/ShellCommand.java?r=29

I have tried to execute "ping -c 3 www.google.com", but the given method returns "Error: null". The way I execute the command is:

ShellCommand cmd = new ShellCommand();
CommandResult r = cmd.sh.runWaitFor("ping -c 5 www.google.com");
String text;
if (!r.success()) {
    text = "Error:\n" + r.stderr;
}
else {
    text ="Ping test results:\n" + r.stdout;
}
log(text);

Where is the problem?

Do not run shell commands from a production app. These are not part of the Android SDK. `ping` may or may not exist on any given device, and `ping` may or may not exist in any given version of Android. — CommonsWare, Mar 18 '11 at 13:25
I posted an edit to my answer that shows one way you can ping without shell. — FoamyGuy, Mar 18 '11 at 14:15
See how to do it here: http://stackoverflow.com/questions/2786720/android-service-ping-url — Oded Regev, Oct 26 '14 at 12:05

score 3 · Answer 1 · edited Sep 16 '15 at 16:27

You have probably solved this by now. But telling you you shouldn't do it seemed like no answer to me. Obviously if the ping command doesn't exist you can't call it and you can handle the error. But if it does, wow!

Here is a way to do it. Works on the emulator 2.1 anyway. The emulator likes to be started after you have a good Internet connection though. If you start the emulator and change your connection somehow, it may not work after that. I didn't need any permissions to do it either on the emulator.

public class Rooted extends Activity {
    EditText body;

    @Override
    public void onCreate(Bundle icicle) {
        super.onCreate(icicle);
        setContentView(R.layout.main);
        body = (EditText)findViewById(R.id.bodyEditText);
        try {
        Process process = Runtime.getRuntime().exec("/system/bin/ping -c 1 betterpaving.com");
        BufferedReader reader = new BufferedReader(
                new InputStreamReader(process.getInputStream()));
        int i;
        char[] buffer = new char[4096];
        StringBuffer output = new StringBuffer();
        while ((i = reader.read(buffer)) > 0) output.append(buffer, 0, i);
        reader.close();
        body.append(output.toString()+"\n");
        } 
        catch (IOException e) {
            body.append("Error\n");
            e.printStackTrace();
            } 
        }//oncreate

    //TODO: Fill In Methods Etc.

    //"ping -c 1 betterpaving.com" try this sometime
}//class

It's different from yours anyway and needs to be put somewhere besides the create block, but...

score 1 · Accepted Answer · edited May 23 '17 at 11:58

1

Do you have Internet permission for your app? And is the device connected to the Internet? Is there any output in the Logcat?

This question shows a one method you could use to ping from Java, without needing to run the shell command.

edited May 23 '17 at 11:58

Community

1
1

answered Mar 18 '11 at 13:24

FoamyGuy

46,603
18
125
156

Yes, I have permissions and the device is connected to the internet. – StalkerRus Mar 18 '11 at 14:10

Running ping command in the shell from app

2 Answers2

Linked