Variables not available in callback?

Asked Dec 08 '18 at 17:49

Active Dec 08 '18 at 17:49

Viewed 23 times

I'm looping through some results and saving them in a MongoDB.

let newSaved = 0
let dupes = 0

items.forEach(d => {
  let newItem = new Item({ ...d })

  newItem.save(err => {
    if (err) {
      dupes += 1
      page = null
    } else {
      newSaved += 1
    }
  })
})

console.log(`Finished page ${page}`)
console.log(`New: ${newSaved} - Dupes: ${dupes}`)

The final console.log always outputs newSaved and dupes as zero. I'm sure it's a scope thing and perhaps it's just my pre-caffeinated brain missing out on something normal. Any insight?

asked Dec 08 '18 at 17:49

opticon

3,494
5
37
61

1

It seems that Item.prototype.save() is async, so the console.logs are executed first – Rafael Dec 08 '18 at 17:52
Is your `newItem.save` async? If so then your `forEach` is likely ending before all the saves – Neil Stevens Dec 08 '18 at 17:53
Another post that might help: [Using async/await with a forEach loop](https://stackoverflow.com/questions/37576685/using-async-await-with-a-foreach-loop) – Jonathan Lonowski Dec 08 '18 at 18:00

Variables not available in callback?

0 Answers0