Javascript forEach() skips items

Question

I am new to javascript. Simply i want to remove all objects with completed: true.

But my function doesn't do that. What am i missing ?

const todo = [{
    title: 'do this',
    completed: true
},{
    title: 'do this',
    completed: true
},{
    title: 'do this',
    completed: true
},{
    title: 'do this',
    completed: true
}]

const remove = function(todo){
    todo.forEach(function(item,index){      

        if(item.completed){            
            todo.splice(index,1)        
        }
    })

}

remove(todo)
console.log(todo)

If you are going to remove items in a loop, you need to loop over the array backwards otherwise use filter. — Get Off My Lawn, Dec 12 '18 at 22:00

score 1 · Accepted Answer · edited Dec 12 '18 at 22:05

1

You could use Array.prototype.filter instead:

const undone = todo.filter((item) => !item.completed)
const completed = todo.filter((item) => item.completed)

edited Dec 12 '18 at 22:05

Get Off My Lawn

34,175
38
176
338

answered Dec 12 '18 at 22:02

tkone

22,092
5
54
78

Javascript forEach() skips items

1 Answers1