Javascript promise not populating response

Question

I thought I understood promises until this happened. I know there are ALOT of similar questions on SO but after going through many many and redoing promises this simple problem is not getting solved. I have been reading and trying but cannot find out how to fix this without using a callback function and not using a .then

const searchResponse = await performSearch(options);
if (searchResponse.error) {
    response.error = searchResponse.error;
}
else {
    response = orchestrateShareClassSearchResponse(searchResponse['data']);
}
return Promise.resolve(response);

The problem is searchResponse['data'] is always sent as an empty object and the result from performSearch ( async function performSearch) is not populated. I also tried await searchResponse['data'] but to no avail.

Sometimes a something tiny can really bug. Does anyone have any ideas besides using callbacks ?

I am posting the performSearch as well although didn't wan't to complicate the problem:

export async function performSearch(options, callingMethod: string, callback?: Function): Promise<IActionResponse<ISearchEntityResponse>> {
    const baseSearchRequest = Object.assign({}, BASE_SEARCH_REQUEST, options);
    let response = <IActionResponse<ISearchEntityResponse>>{};
    let searchResponse;// = await performSearch(options);
        const io = require('socket.io-client');
        const socket = io.connect();
        socket.on('connect', function (data) {
            console.log('CONNECTED TO CLIENT SOCKET');

            socket.emit('fetchShareClasses', null);
            socket.on('fetchShareClasses', async function (searchResponse) {
                console.log('sNullOrUndefined(searchResponse)::', isNullOrUndefined(searchResponse));
                if (searchResponse === null) {

                    searchResponse = await fetch(ENDPOINTS.fund.searchEntity, generateRequest('POST', baseSearchRequest)).then(function (searchResponse) {

                        console.log('NULL recieved do call to get DATA');
                        socket.emit('fetchShareClasses', searchResponse);
                    });
                }
                else {
                    console.log('fetchShareClasses CLIENT REACHED');
                    response = searchResponse;

                }
            });
        });
        return Promise.resolve(response);
}

Just `return response`, no need for another Promise wrapper. — Jonas Wilms, Dec 21 '18 at 06:45
The bug is in `performSearch`, you must use a `new Promise` wrapper and `resolve` it from the asynchronous `fetchShareClasses` event. — Bergi, Dec 21 '18 at 06:50
This is terribly disappointing. It's easy to say a question is duplicate but I have mentioned that I have read and tried many similar answers on SO. The link provided also uses a callback mechanism and that is what I was trying to get away from. I do not want to wrap many many lines of code in an .then or callback. — Afshin Ghazi, Dec 21 '18 at 06:53
@BergiI Also had tried that but got error: "Only void function can be called with the new Promise keyword" — Afshin Ghazi, Dec 21 '18 at 06:56
`return Promise.resolve(response);` this is not needed, just do `return response;` — Kunal Mukherjee, Dec 21 '18 at 06:57
@KunalMukherjee I had already tried that also but out of seeing no other options tried to do the Promise.resolve thing. Even without Promise.resolve it does not work — Afshin Ghazi, Dec 21 '18 at 07:01
`orchestrateShareClassSearchResponse()` does it return a promise? — Kunal Mukherjee, Dec 21 '18 at 07:07
so you can just do `response = await orchestrateShareClassSearchResponse(searchResponse['data']);` — Kunal Mukherjee, Dec 21 '18 at 07:30
@KunalMukherjee The problem is not that I am not getting the correct data coming in from "orchestrateShareClassSearchResponse". The issue is that I am not passing the correct data to it -> "searchResponse['data']" is empty. — Afshin Ghazi, Dec 21 '18 at 07:41

Javascript promise not populating response

0 Answers0