Javascript SyntaxError: missing

Question

I'm trying to put 2 scripts in 1 js file and i'm getting:

SyntaxError: missing } after property list
note: { opened at line 9, column 19

But as far as I check all the curly brackets are closed, not sure what the real issue is.

Code

// country
jQuery( document ).ready( function( $ ) {
    $('select[name="country"]').on('change', function() {
      $.ajaxSetup({
          headers: { 'X-CSRF-TOKEN': $('meta[name="_token"]').attr('content') }
      });
       var CountryId = $(this).val();
        if(CountryId) {
            $.ajax({
              url: '{{ url('getprovinces') }}/'+encodeURI(CountryId),
              type: "GET",
              dataType: "json",
              success:function(data) {
                $('select[name="province"]').empty();
                var options = data.map(function(state) {
                    return $("<option class='form-control'>").val(state.id)
                                        .text(state.name);
                });
                $('select[name="province"]').empty().append(options);
              }
            });
        }else{
          $('select[name="province"]').empty().append("<option class='form-control' value='' selected>Select</option>");
        }
    });
});

error comes from this line:

url: '{{ url('getprovinces') }}/'+encodeURI(CountryId),

Any idea?

I think, your code is not in laravel blade, it is in a separate js file. Don't use blade syntax in javascript — Tamil Selvan C, Dec 24 '18 at 04:35
`"{{ url('getprovinces') }}/"+encodeURI(CountryId)` This will work — Rajender Joshi, Dec 24 '18 at 04:38
@RajenderJoshi if you do so, do you think `url('getprovinces')` will be populated? — PPShein, Dec 24 '18 at 04:44
@SanjaysinhZala i select country and it returns provinces names the only obstacle is that my js code isn't in my blade file it's loading from external js file — mafortis, Dec 24 '18 at 04:45
@PyaePhyoeShein i have the exact code in different app and it's working the only difference is in that app my js file is in blade file and in this one is in external js file — mafortis, Dec 24 '18 at 04:46

score 1 · Answer 1 · answered Dec 24 '18 at 04:34

1

You need to escape the quotes or use a double-quoted string. Otherwise JS thinks the string ends on the quote after url(' then gets confused when a variable name pops up.

answered Dec 24 '18 at 04:34

kingdaro

11,528
3
34
38

PPShein · Answer 2 · 2018-12-24T04:42:12.060

0

Try like that:

// country
jQuery( document ).ready( function( $ ) {
    $('select[name="country"]').on('change', function() {
      $.ajaxSetup({
          headers: { 'X-CSRF-TOKEN': $('meta[name="_token"]').attr('content') }
      });
       var CountryId = $(this).val();
        if(CountryId) {
            $.ajax({
              url: '{{' + url('getprovinces') + '}}/' + encodeURI(CountryId),
              type: "GET",
              dataType: "json",
              success:function(data) {
                $('select[name="province"]').empty();
                var options = data.map(function(state) {
                    return $("<option class='form-control'>").val(state.id)
                                        .text(state.name);
                });
                $('select[name="province"]').empty().append(options);
              }
            });
        }else{
          $('select[name="province"]').empty().append("<option class='form-control' value='' selected>Select</option>");
        }
    });
});

edited Dec 24 '18 at 04:42

answered Dec 24 '18 at 04:36

PPShein

13,309
42
142
227

what is value of `url('getprovinces')`? – PPShein Dec 24 '18 at 04:47
this is the route `Route::get('/getprovinces/{countryid}','Front\AddressLists@getprovinces');` it returns provinces as json – mafortis Dec 24 '18 at 04:48
so far, above my code is not problem. there should be problem `url('getprovinces')` – PPShein Dec 24 '18 at 04:49
wth..!! why did you pass those kinda json data to url? better `post` method instead for those `getprovinces` data. – PPShein Dec 24 '18 at 04:52
so you suggest i change my route to post? – mafortis Dec 24 '18 at 05:11
yap, exactly. it should be post. – PPShein Dec 24 '18 at 05:49
but i want to get data from database and not save to database. to getting data from database my route should be GET i think no? – mafortis Dec 24 '18 at 05:54

score 0 · Answer 3 · answered Dec 24 '18 at 04:56

0

Try

url: url('getprovinces') + '/' + encodeURI(CountryId),

answered Dec 24 '18 at 04:56

holydragon

6,158
6
39
62

Javascript SyntaxError: missing

Code

3 Answers3