How to deal with != and || in c#

Question

Im new to c# and not great at coding in general. Trying to learn. I want this game to detect when my object hits something to see if it hits something that isnt the ground or the finish and then reload the scene if it does. First i tried :

public class wallCollision : MonoBehaviour  
{  

    public Rigidbody rb;
    public Vector3 spawn;

    void OnCollisionEnter(Collision col)
    {
        if (col.gameObject.name != "Ground")
        {
            Scene scene = SceneManager.GetActiveScene(); 
            SceneManager.LoadScene(scene.name);
        }
    }
}

And it worked so then i changed it to this to check for the finish as well.

public class wallCollision : MonoBehaviour
{
    public Rigidbody rb;
    public Vector3 spawn;

    void OnCollisionEnter(Collision col)
    {
        if (col.gameObject.name != "Ground" || "Finish")
        {
            Scene scene = SceneManager.GetActiveScene(); 
            SceneManager.LoadScene(scene.name);
        }
    }
}

It didn't work which is why i need help. I want it to think out like:

If object collides with anything and that isn't ground or finish then.

I know I'm probably doing some simple mistake but i don't know what to search for to find help so if any one can help it would be appreciated. Thanks in advance.

I think you want something like `col.gameObject.name != "Ground" && col.gameObject.name != "Finish"` — DavidG, Dec 24 '18 at 12:56

score 0 · Accepted Answer · answered Dec 24 '18 at 13:00

0

You have to compare the initial value against both test values:

if (col.gameObject.name != "Ground" && col.gameObject.name != "Finish")
{ }

Another option would be using a collection and Contains, but that is worse from a performance point of view:

if (!(new string[] { "Ground", "Finish" }.Contains(col.gameObject.name)))
{ }

answered Dec 24 '18 at 13:00

Patrick Hofman

153,850
22
249
325

Thanks man. The first one worked a charm! – Henry Booher Dec 24 '18 at 13:01

zzdhxu · Answer 2 · 2018-12-24T13:03:05.143

-1

I need you need something like this instead

col.gameObject.name != "Ground" && col.gameObject.name != "Finish"

Not too sure but is there a code that is .Equals() or something like that

edited Dec 24 '18 at 13:03

answered Dec 24 '18 at 12:59

zzdhxu

379
6
22

That would always yield `true`. – Patrick Hofman Dec 24 '18 at 13:00
User mentioned or finished so it should be == to Finish – zzdhxu Dec 24 '18 at 13:04

How to deal with != and || in c#

2 Answers2