I have a file with names, surnames, ids, and e-mails which is in a random order. I have to organize these datas, write to structures and to an output file as organized. There may be more than one name and surname. Here is an example of disordered.txt:
abc@gmail.com Andee Kenny SMITH 1234
ADAM ADAM abc@gmail.com Andeee 21654
Anderea abc@gmail.com SAMMY 3524654
abc@gmail.com Andi BROWN 1245
Andie abc@gmail.com KNOWY 2485
Andra abc@gmail.com BRUCE 52445
Andrea abc@gmail.com 246574 DENNIS
2154 Andreana abc@gmail.com CHASE
Andree 21524 SIERRRA abc@gmail.com
Andrei 154 MONDY abc@gmail.com
4564765 Andria LE BARC abc@gmail.com
78 Andriana abc@gmail.com WALLS
My code works fine with this 12 people but if I copy-paste it a lot or add new people, after 33 people, it prints invalid characters in front of the names and surnames in repeating manner.
Here is the screenshot of: organized.txt
I preferred to use char pointers in my structure.
Here is my code:
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#define TRUE 1
#define WORD_SIZE 30
#define NAME 1
#define SURNAME 2
#define EMAIL 3
#define ID 4
typedef struct ppl {
char* name;
char* surname;
char* eMail;
int id;
} PEOPLE;
int whichDataType (char* buffer);
void writeData (PEOPLE* person, char* buffer, int whichData, int* nameTimes, int* surnameTimes, int personNumber);
void printData (PEOPLE* person, FILE* sptr, int personNumber);
int main (void) {
FILE* fptr = NULL;
fptr = fopen("disorganized.txt", "r");
if (fptr == NULL) {
printf ("Disorganized file couldn't open\n");
printf ("Exiting the program\n");
exit(TRUE);
}
FILE* sptr = NULL;
sptr = fopen("organized.txt", "w");
if (sptr == NULL) {
printf ("Organized file couldn't open\n");
printf ("Exiting the program\n");
exit(TRUE);
}
int whichData;
int personNumber = 0;
int* nameTimes;
int* surnameTimes;
int forOnce = 0;
char* buffer;
int* buffer2;
PEOPLE* person;
person = (PEOPLE*) malloc (sizeof(PEOPLE));
buffer = (char*) malloc ( WORD_SIZE * sizeof(char));
nameTimes = (int*) malloc ( sizeof(int));
surnameTimes = (int*) malloc (sizeof(int));
*nameTimes = 0;
*surnameTimes = 0;
//gets word 'till EOF
while ((fscanf(fptr, "%s", buffer)) == 1) {
if (personNumber != 0) {
//creates new structure
person = (PEOPLE*) realloc (person, personNumber * sizeof(PEOPLE));
}
//looks what type of data
whichData = whichDataType(buffer);
//allocates inside of structures and writes
writeData(person, buffer, whichData, nameTimes, surnameTimes, personNumber);
buffer2 = (int*) malloc (sizeof(int));
*buffer2 = fgetc(fptr); //checks what's coming next
if (*buffer2 == '\n') {
if (forOnce == 0) {
//to open a place for next person in my structure pointer, since personNumber = 0; increasing it with 1 and reallocating it with 1*sizeof(PEOPLE) would be the allocating memory for person 1 twice.
personNumber = personNumber + 2;
free(buffer2);
free(buffer);
buffer = (char*) malloc ( WORD_SIZE * sizeof(char));
*nameTimes = 0;
*surnameTimes = 0;
++forOnce;
}
else {
++personNumber;
free(buffer2);
free(buffer);
buffer = (char*) malloc ( WORD_SIZE * sizeof(char));
*nameTimes = 0;
*surnameTimes = 0;
}
}
else if (*buffer2 == ' ' || *buffer2 == '\t') {
free(buffer2);
free(buffer);
buffer = (char*) malloc ( WORD_SIZE * sizeof(char));
}
}
--personNumber; //my algorithm increases it 1 more time which is redundant
printData (person, sptr, personNumber);
int i;
for (i = 0; i<personNumber; ++i) {
free((person+i)->name);
free((person+i)->surname);
free((person+i)->eMail);
}
free(person);
free(buffer);
free(buffer2);
free(nameTimes);
free(surnameTimes);
fclose(fptr);
fclose(sptr);
return 0;
}
int whichDataType (char* buffer) {
if (buffer[0] >= 'A' && buffer[0] <= 'Z') {
if (buffer[1] >= 'a' && buffer[1] <= 'z') {
return NAME;
}
else if (buffer[1] >= 'A' && buffer[1] <= 'Z') {
return SURNAME;
}
}
else if (buffer[0] >= 'a' && buffer[0] <= 'z') {
return EMAIL;
}
else if (buffer[0] >= '0' && buffer[0] <= '9') {
return ID;
}
}
void writeData (PEOPLE* person, char* buffer, int whichData, int* nameTimes, int* surnameTimes, int personNumber) {
if (personNumber != 0) {
--personNumber;
}
switch (whichData) {
case NAME:
if (*nameTimes == 0) {
(person + personNumber)->name = (char*) malloc ( WORD_SIZE * sizeof(char));
++(*nameTimes);
}
break;
case SURNAME:
if (*surnameTimes == 0) {
(person+personNumber)->surname = (char*) malloc ( WORD_SIZE * sizeof(char));
++(*surnameTimes);
}
break;
case EMAIL:
(person + personNumber)->eMail = (char*) malloc ( WORD_SIZE * sizeof(char));
break;
}
char space[2];
strcpy(space, " ");
switch (whichData) {
case NAME:
if (*nameTimes == 0) {
strcpy( (person+personNumber)->name, buffer);
}
else {
strcat ( (person+personNumber)->name, space);
strcat( (person+personNumber)->name, buffer);
}
break;
case SURNAME:
if (*surnameTimes == 0) {
strcpy ( (person+personNumber)->surname, buffer);
}
else {
strcat( (person + personNumber)->surname, space);
strcat( (person + personNumber)->surname, buffer);
}
break;
case EMAIL:
strcpy( (person + personNumber)->eMail, buffer);
break;
case ID:
(person+personNumber)->id = atoi(buffer);
break;
}
}
void printData (PEOPLE* person, FILE* sptr, int personNumber) {
fprintf(sptr, "-------------------------------------------------------------------------------------------------------------------------------------------------------------------");
fprintf(sptr, "\n|%30s\t\t", "***NAME***");
fprintf(sptr, "|%30s\t\t", "***SURNAME***");
fprintf(sptr, "|%30s\t\t", "***E-MAIL***");
fprintf(sptr, "|%30s\t|\n", "***ID NUMBER***");
fprintf(sptr, "-------------------------------------------------------------------------------------------------------------------------------------------------------------------");
int i;
for (i = 0; i<personNumber; ++i) {
fprintf(sptr, "\n|%d%30s\t\t", i, (person+i)->name);
fprintf(sptr, "|%30s\t\t", (person+i)->surname);
fprintf(sptr, "|%30s\t\t", (person+i)->eMail);
fprintf(sptr, "|%30d\t|\n", (person+i)->id);
fprintf(sptr, "-------------------------------------------------------------------------------------------------------------------------------------------------------------------");
}
}
I try to malloc every new struct and inside of it, free my buffers after I finish my work with them and allocate them again for next ones. If there is more than one name or surname for one person, I allocate its name or surname once and and strcpy my buffer to appropriate place. If I go to my writeData function for name or surname again for same person, I pass the allocated memory because I already did that. Then I'm basically concatenating my new buffer (name or surname) next to old one.
My question is, why am I getting these invalid characters, where did I make a mistake and how can I prevent it?
