PHP - check if time between 22:00 and 02:00

Question

i have the following code :

$now = date('2018-12-28 23:00:00');
$begintime = new DateTime('22:00');
$endtime = new DateTime('03:00');

if($now >= $endtime && $now <= $begintime){
// not between times
echo "Run";
} else {
// between times
echo "Skip";
}

and the echo is

Skip

because $now is bigger than $begintime that make the output is false
what is the correct way to know if time is not the between the $begintime and $endtime?
I searched all of the relevant issues and I've just wasted 3 days of my life because of this issues, but couldn't find something that even elucidated anything from this forum and google for me. Please help me this issue has already taken an absurd amount of days from my life already and sorry for my english before.. :D

Answer 1

Your code displays enormous amount of misunderstanding of how things are working and it leads to the problem. Please take a look at official documentation, you will see that date() returns string and DateTime is an object. They can't be compared directly, you need to convert them into comparable types beforehand. Also notice that DateTime expects to get a date, not just time. Actually without date being defined your $endtime is actually smaller then $starttime:

$begintime = new DateTime('22:00');
$endtime = new DateTime('03:00');

echo $begintime < $endtime ? 'Yes':'No';

This code snippet will return No.

You need to convert $now to a DateTime and you need to add dates to your start / end time marks. For example:

$now = \DateTime::createFromFormat('Y-m-d H:i:s', '2018-12-28 23:00:00', new \DateTimeZone('UTC'));

I can't provide example of converting start / end time marks because you have not defined how do they actually need to look like.

Answer 2

One solution may be :

$now = "23:00"; // date ('H:i');
$begintime = "22:00";
$endtime = "03:00";

$now_t = DateTime::createFromFormat('H:i', $now);
$begintime_t = DateTime::createFromFormat('H:i', $begintime);
$endtime_t = DateTime::createFromFormat('H:i', $endtime);

if ($now_t > $begintime_t || $now_t < $endtime_t)
{
 echo "Skip";
}
else
{
 echo "Run";
}

Answer 3

UPDATE

finnaly, i solve my problem..
can someone remove the duplicate tags from my question and find the correct title for this issue? maybe someone who have same issue like me, can search my question and find the answer..
sorry for my english, i still learning..

// this is variable from mysql database
$mysql_start = "2018-12-28 21:45:00";  // its from mysql DATETIME and time show when this script will be run
$begintime = "22:00"; // user can choose when this script stop
$endtime = "20:00"; // user can choose when this script run


$mysql_start = explode(' ', $mysql_start);
$taskdays = $mysql_start[0]; // 2018-12-28
echo $taskhours = $mysql_start[1]; // 21:45:00
echo "<br>";
$taskhours = explode(':',$taskhours);
$taskhours = $taskhours[0]; // 22
echo $begintime = date($begintime);
echo "<br>";
$begintime = explode(':',$begintime);
$begintime = $begintime[0]; // 20
echo "<br>";
echo $endtime = date($endtime);
echo "<br>";
$endtime = explode(':',$endtime);
$endtime = $endtime[0] - 1; // because if endtime is 6, so if its 05:59, the endtime will be end on 05
echo $endtime = str_pad($endtime, 2, '0', STR_PAD_LEFT); // if 6, it will add 0 so it will be 06
echo "<br>";
$jamarray = array("00","01","02","03","04","05","06","07","08","09","10","11","12","13","14","15","16","17","18","19","20","21","22","23");
$ray = array();
if ($begintime > $endtime){
    echo '$begintime is bigger than $endtime<br>';
foreach($jamarray as $ray) {
        if($ray >= $begintime or $ray <= $endtime){
            //echo '<br>';
            //print_r($ray);
            $eray[] = $ray;
        }
}
$aslinya = array_diff($jamarray,$eray); 
print_r($aslinya);
if (in_array($taskhours, $aslinya))
  {
  echo " <= script run in this time";

  }

}else{

    echo '$begintime is less than $endtime<br>';
foreach($jamarray as $ray) {
        if($ray >= $begintime and $ray <= $endtime){
            //echo '<br>';
            //print_r($ray);
            $eray[] = $ray;
        }
}
$aslinya = array_diff($jamarray,$eray);
print_r($aslinya);
if (in_array($taskhours, $aslinya))
  {
  echo " <= script run in this time";
  } 


}