Why does this script don't work in external js file?

Question

When I put this code in HTML file, my slideshow works, but when I put it in an external js file, the slideshow doesn't work. why?

https://i.stack.imgur.com/5KtOK.jpg ............................................................

full code html: https://pastebin.com/YiZhpYzk javascript file: https://pastebin.com/11BNhL7G

var myIndex = 0;    
carousel();

function carousel() {
    var i;
    var x = document.getElementsByClassName("mySlides");
    for (i = 0; i < x.length; i++) {
        x[i].style.display = "none";  
    }
    myIndex++;
    if (myIndex > x.length) {myIndex = 1}    

    x[myIndex-1].style.display = "block";  
    setTimeout(carousel, 1300); 
}

Pictures of code are not helpful. Please add any relevant code directly to your quesiton. — jmargolisvt, Jan 05 '19 at 18:45
How are you referencing the script file in the HTML file? Do you miss `` by chance? — Tomáš Hübelbauer, Jan 05 '19 at 18:46
javascript file works, but not like i would add this script in html file — Andu Mîndrescu, Jan 05 '19 at 18:49
place the external javascript file at the bottom of the body section of the HTML file instead head section. — Dulara Malindu, Jan 05 '19 at 19:12
hey man, like @DularaMalindu spoke, you have put the import JS in final of your code. Try this: ...

... Your code is work pefectly, but is being called before the your html code is bind. — MarcusVinnicius, Jan 06 '19 at 12:30
Indeed @MarcusVinnicius, at the time he calls the function the DOM is not loaded. otherwise, he has to execute the function after the document completes it's loading. — Dulara Malindu, Jan 06 '19 at 12:54

score -1 · Answer 1 · answered Jan 05 '19 at 18:59

-1

Try placing the entry point of the link to your js document which includes the function in different places like just before the the tag and make sure the link to your css is correct.

answered Jan 05 '19 at 18:59

user3130049

1
4

if in js document I write alert("asdasd") it works so it's not this... – Andu Mîndrescu Jan 05 '19 at 19:06
Are you trying to make it work on your own computer or in the cloud? Either way tru using an absolute url – user3130049 Jan 05 '19 at 19:14

Why does this script don't work in external js file?

1 Answers1

Linked