Rails: Shoulda-matchers belong_to optional test

Question

I have a model

class Certificate < ApplicationRecord
  notification_object
  belongs_to :user
  belongs_to :share_class, optional: true
  belongs_to :round, optional: true
  belongs_to :company, optional: true
  has_many :approvals, as: :votable
end

The spec for this model looks like this

require 'rails_helper'

RSpec.describe Certificate, type: :model do
  it { should belong_to(:user) } 
  it { should belong_to(:share_class).optional } 
  it { should belong_to(:round).optional } 
  it { should belong_to(:company).optional } 
  it { should have_many(:approvals) } 
end

But when I run this spec I get this error

1) Certificate is expected to belong to share_class optional: true

     Failure/Error: it { should belong_to(:share_class).optional }
       Expected Certificate to have a belongs_to association called share_class (the association should have been defined with`optional: true`, but was not)
     # ./spec/models/certificate_spec.rb:5:in `block (2 levels) in <top (required)>'

I do not know why I'm getting this error.

do the other optional specs pass? – Anthony Jan 09 '19 at 18:16 — Anthony, Jan 09 '19 at 18:16
@Anthony Yes it does that's why its confusing to me – meerkat Jan 10 '19 at 07:31 — meerkat, Jan 10 '19 at 07:31

Michael Arkhipov · Accepted Answer · 2019-07-24T17:39:13.990

25

For the first, you should read this conversation.

@mcmire We have a pre-release version out now! Try v4.0.0.rc1 to get optional.

And then, the expected code should look like this:

RSpec.describe Certificate, type: :model do
  it { should belong_to(:user) } 
  it { should belong_to(:share_class).optional } 
  it { should belong_to(:round).optional } 
  it { should belong_to(:company).optional } 
  it { should have_many(:approvals) } 
end

edited Jul 24 '19 at 17:39

answered Jan 09 '19 at 17:59

Michael Arkhipov

737
8
19

1

Are you sure? I don't think `optional` method accepts any arguments either on master and 4.0.0 https://github.com/thoughtbot/shoulda-matchers/blob/master/lib/shoulda/matchers/active_record/association_matcher.rb#L1070 https://github.com/thoughtbot/shoulda-matchers/blob/v4.0.0.rc1/lib/shoulda/matchers/active_record/association_matcher.rb#L1070 – jedi Jan 09 '19 at 21:43
@jedi As you can see, I quoted the creator of the shoulda-matchers (@mcmire). And yes. I'm sure those words correct. P.s. v4.0.0.rc1 – Michael Arkhipov Jan 10 '19 at 01:39
@MichaelArkhipov I have the pre - release version but its not working on that. Also the belong_to round and belong_to company tests are running fine so I don't know whats wrong with the first one – meerkat Jan 10 '19 at 07:25
1

`optional` does not take an argument (anymore?) https://github.com/thoughtbot/shoulda-matchers/blob/master/lib/shoulda/matchers/active_record/association_matcher.rb#L304 so it is just `should belong_to(:something).optional` – Pascal Jul 24 '19 at 08:45

score 6 · Answer 2 · answered Apr 24 '20 at 23:04

class Person < ActiveRecord::Base
  belongs_to :organization, optional: true
end

# RSpec
describe Person
  it { should belong_to(:organization).optional }
end

# Minitest (Shoulda)
class PersonTest < ActiveSupport::TestCase
  should belong_to(:organization).optional
end

Documentation

Rails: Shoulda-matchers belong_to optional test

2 Answers2