list array not changing in model list

Question

Everything is ok but after auth process the _humans list not changing. The last one must add token into list array.

my list array

public List<Human> _humans = new List<Human>
{
  new Human ( 1,"test","false","asd" )
};

-- non working method:

[HttpGet]
public async Task<IActionResult> register( Human employee)
{
  ....
  await HttpContext.SignInAsync(principles);

  humans.Add(new Human(22,"ASDDD","AAS",employee.token));

  return RedirectToAction("Index","Home");
}

a local list in homecontroller file when i visit index() it adds value to array, but with register () it doesnt add into list — barron, Jan 15 '19 at 11:07
in another method.in getvalues() method i try to get values with jsonresult, but list stays unaffected — barron, Jan 15 '19 at 11:40
[Authorize] [AutoValidateAntiforgeryToken] [HttpGet] public ObjectResult Index() { return new ObjectResult(_humans); } — barron, Jan 15 '19 at 11:42
no errrors on webpage it normally returns json but which is un affected list. — barron, Jan 15 '19 at 11:45

score 0 · Accepted Answer · answered Jan 15 '19 at 11:45

0

As stated in this answer a new controller instance will be constructed for each request. So for each request a new list will be created and everything added to it will be lost at the end of the request.

To persist your data you should serialize it to a database or file. You could also make the list static but then the data will still be lost when the application restarts.

answered Jan 15 '19 at 11:45

ColmanJ

457
2
12
28

where can i put the static list ? – barron Jan 15 '19 at 11:48
By changing `public List _humans = ...` to `public static List _humans = ...`. – ColmanJ Jan 15 '19 at 11:50
@barron He is right! You can put the keyword static after the public modifier. – Filipe Donde Jan 15 '19 at 11:51
This will most likely solve your issue. However, it may also create other problems. Static lists are [not threadsafe](https://stackoverflow.com/a/8197202/4949005). – smoksnes Jan 15 '19 at 13:04
That's true, I'd recommend looking into something like entity framework. – ColmanJ Jan 15 '19 at 13:12

list array not changing in model list

1 Answers1