Response.Write() with javascript doesn't work properly

Question

I'm having a problem with this code:

Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load

    clave = Request.QueryString("cve")

    If clave = Nothing Then
        Response.Write("<script language='javascript'>alert('Querystring is empty');window.close();</script>")
        Return
    End If

    Dim valid As Boolean
    valid = Regex.Match(clave, "\b\d{3}\-\d{3}\-\d{3}\b").Success

    If valid = False Then
        Response.Write("<script language='javascript'>alert('Wrong format');window.close();</script>")
        Return
    End If

'More Code
End Sub

The thing is that, the first if statement works fine and the 'javascript' shows an alert and close the window, but in the second if statement the javascript shows the message but doesn't close the window.

Do you guys know how to fix this?

When you go into that particular code path, is the window the javascript echoes into one that was opened by a script to begin with? — Marc B, Mar 24 '11 at 19:50
ah, the exit sub doesn do anything it was one of my tests, sorry. Fixed. — Eduardo Rascon, Mar 24 '11 at 19:53
@Marc B, I didn't understand your question, my english is not good, but this code is meant to be executed in the same window. Is that what you meant? — Eduardo Rascon, Mar 24 '11 at 19:57

score 1 · Answer 1 · answered Mar 24 '11 at 19:50

1

The code seems fine.

Try to use Client.RegisterScriptBlock instead.

answered Mar 24 '11 at 19:50

Guilherme Duarte

3,371
1
28
35

+1 You really shouldn't be writing js directly to the response. – Rex Morgan Mar 24 '11 at 19:56

score 1 · Answer 2 · answered Mar 24 '11 at 19:50

1

window.close(); is correct, but for security reasons, most browsers won't let you close windows you didn't open.

answered Mar 24 '11 at 19:50

nitro2k01

7,627
4
25
30

I'm using Chrome 10, but I dont thing thats the problem, beacuse the window.close in the first Response.write does work. – Eduardo Rascon Mar 24 '11 at 19:55
Might want to check these: http://stackoverflow.com/questions/760422/how-can-i-close-a-window-with-javascript-on-mozilla-firefox-3 and http://forums.asp.net/t/1264584.aspx – gbs Mar 25 '11 at 02:04

Response.Write() with javascript doesn't work properly

2 Answers2