Spring Boot + JPA : @Transactional annotation : Roll back is not working

Question

I am using @Transactional with spring boot and jpa. But it is not working. Can somebody help out.

My inserts are in myDAO which is autowired in service class. Below code is method of service class which is implementing service interface

class MyService implements Service {

@Transactional(rollbackFor = RuntimeException.class)
    public ResponseVO createOrder(params) {
    myDAO.insertInTable1(param);
    myDAO.insertInTable2(param);//I kept wrong table name in this query such that it throws exception
         }

 }

Your rollback is only for `RuntimeException`, and wrong table don't create an `RuntimeException`. Read the `@Transactional` manual. — Zorglube, Jan 21 '19 at 15:29
@Zorglube, I tried with creating new Runtime Exception with new. Even though no rollback. — Naveen Yalla, Jan 21 '19 at 15:33
It seems you don't understand what you're doing, you don't need to forge an exception yourself, you need to choose for what kind of exception you rollback or not. — Zorglube, Jan 21 '19 at 15:36
Show the `MyDao` implementation, also which database are you using? If you are using MySQL make sure you are using a table store that supports transactions. — M. Deinum, Jan 21 '19 at 18:49
I am using MYSql, with engine MyISAM. in DAO I am just inserting data into table1 and table 2 using JPA save and saveall methods.(JPARepository) — Naveen Yalla, Jan 22 '19 at 05:41
If you want to rollback a transaction on an Exception then the method `must` throw an Exception... You're not throwing one here... add `public ResponseVO createOrder(params) throws Exception {...}` — Edward J Beckett, Jun 27 '19 at 18:09

score 6 · Accepted Answer · answered Jan 22 '19 at 06:14

6

Issue is with MySQL Database engine. My engine was MYIsam which doesn't supports Transactions. I changed my DB engine to InnoDB and its working. Thanks for the contributions. Below are the queries for the same.

SELECT ENGINE FROM information_schema.TABLES WHERE TABLE_NAME = 'tabel_name' AND TABLE_SCHEMA='db_name';

ALTER TABLE table_name ENGINE = INNODB;

answered Jan 22 '19 at 06:14

Naveen Yalla

141
1
11

For changing to INNODB using the hibernate dialect refer to this https://stackoverflow.com/questions/1459265/hibernate-create-mysql-innodb-tables-instead-of-myisam – Rishi Agrawal Dec 27 '19 at 16:55

score 2 · Answer 2 · answered Jan 21 '19 at 15:36

2

Try this:

@Transactional(propagation = Propagation.REQUIRED, readOnly = false, rollbackFor = RuntimeException.class)

I hope it helps.

Cheers!!

answered Jan 21 '19 at 15:36

Roberto Rodriguez

3,179
32
31

I wouldalso try Exception.class in the rollbackFor part, to discard it is not about the type of Exception being thrown? – Roberto Rodriguez Jan 21 '19 at 19:59
Problem was simple bro.. he didn't have a `throws` clause ;) ```public ResponseVO createOrder(params) {} ``` – Edward J Beckett Jun 27 '19 at 18:08

score 2 · Answer 3 · answered Jan 21 '19 at 16:58

2

RuntimeException are already handled

replace with @Transactional(rollbackFor = Exception.class) to manage all checked exception and will work

answered Jan 21 '19 at 16:58

ValerioMC

2,926
13
24

score 0 · Answer 4 · answered Jan 21 '19 at 15:32

0

Its hard to tell from the amount of code given. I do know that you shouldn't need the rollbackFor if it is RuntimeException. Those are always rolled back. I am guessing your table name error is a SQLException which implements Exception. You would have to have rollbackFor be rollbackFor=SQLException.class, and I would only keep that in while verifying that rollbacks happen. Only add the rollbackFor if you are throwing checked exceptions in methods called by the service.

answered Jan 21 '19 at 15:32

B-Wieg

181
14

I tried that also. But no use. But generally Runtime exception will handle all types of exceptions. So it shoudl catch this exception also and rollback. – Naveen Yalla Jan 21 '19 at 15:35
SQLException is a subclass of Exception, not RuntimeException. RuntimeException is a subclass of Exception. Only subclasses of RuntimeException would get rolled back. – B-Wieg Jan 21 '19 at 15:44

score -1 · Answer 5 · answered Jan 21 '19 at 16:09

In Spring Boot, OpenSessionInView is enabled by default, so your rollback does not work because each time you call myDAO.insertInTableX(), a Commit is performed.

So to remove this behaviour and have your @Transactional works correctly, add this :

spring.jpa.open-in-view=false

To your application.properties

See this question for more

Spring Boot + JPA : @Transactional annotation : Roll back is not working

5 Answers5