Formvalidation with Javascript

Question

i wanted to validate my form but im stuck with the validation of formfield persnr. It won´t compare the string. For this i already tried the comparison and operators (or || ). The validation of the other fields is ok. Did i use the operators wrong?

function checkForm() {
    var strFehler = '';
    if (document.forms[0].user.value == "user")
        strFehler += "user not ok!\n";
    if (document.forms[0].test.value == "")
        strFehler += "test not ok!\n";
    if (document.forms[0].time.value == "")
        strFehler += "time not ok";
    if (document.forms[0].cost.value == "")
        strFehler += "cost not ok!\n";
    if (document.forms[0].persnr.value != "13088") || (document.forms[0].persnr.value != "10286")
    strFehler += "persnr false!\n";
    if (strFehler.length > 0) {
        alert("problems!!: \n\n" + strFehler);
        return (false);
    }
}

I expected that the validation would show an alert if the value isn´t 13088 or 10286 but no message pops up.

The code as posted has a syntax error in the `if` statement for `persnr`. — Pointy, Jan 23 '19 at 14:04

score 1 · Accepted Answer · answered Jan 23 '19 at 14:04

1

This:

if (document.forms[0].persnr.value != "13088") || (document.forms[0].persnr.value != "10286")

Needs to be changed to this:

if ((document.forms[0].persnr.value != "13088") || (document.forms[0].persnr.value != "10286"))

Your are missing parentheses to have both conditions inside the the if statement.

answered Jan 23 '19 at 14:04

Word Rearranger

1,306
1
16
25

1

Yup. OP's browser console should be screaming about this, too. `SyntaxError: expected expression, got '||'` – ceejayoz Jan 23 '19 at 14:09
Thank you. It solved my problem. What would you suggest if i want do compare 5 numbers like in the code above? – D2a Jan 23 '19 at 21:53
This question might help you on this: https://stackoverflow.com/q/4728144/7919626 – Word Rearranger Jan 23 '19 at 22:50

Formvalidation with Javascript

1 Answers1