Script only processes 1st Line of input file

Question

bash script to read a file and process commands remotely. It currently only processes the first line (server1)

Need to remotely process 3 commands on server1 , then server2 ......

#!/bin/bash

while read line; do
    sshpass -f password ssh -o StrictHostKeyChecking=no user@$line zgrep "^A30=" /var/tmp/logs1/messages.* |  >> Output.txt
    sshpass -f password ssh -o StrictHostKeyChecking=no user@$line zgrep "^A30=" /var/tmp/logs2/messages.* |  >> Output.txt
    sshpass -f password ssh -o StrictHostKeyChecking=no user@$line zgrep "^A30=" /var/tmp/logs3/messages.* |  >> Output.txt
done < file1

file1:

server1
server2
server3

That construction may work in some shells, but you probably just want to do `done < file 1 >> Output.txt` — William Pursell, Jan 23 '19 at 15:48

William Pursell · Answer 1 · 2019-01-23T16:30:38.207

4

sshpass is reading from the same file descriptor as the while loop, and exhausting that input before read is able to read it. Best thing is to close its stdin explicitly sshpass <&- ... or redirect from /dev/null sshpass < /dev/null.

Another option is to let sshpass inherit stdin from the script and read from a different file descriptor:

while read line <&3; do 
   ...
done 3< file1

edited Jan 23 '19 at 16:30

answered Jan 23 '19 at 15:43

William Pursell

204,365
48
270
300

Thxs your suggestions worked. – user10956633 Jan 24 '19 at 07:49

Script only processes 1st Line of input file

1 Answers1