Single invited comma in QuerySelector

Question

HTML

<a onclick="loadYearPage('2018-2019')" style="cursor: pointer;">2018-2019</a>

How to target element onclick using CSS selector

i have tried below codes but not working

ie.document.querySelector("[onclick='loadYearPage('2018-2019')']").Click

Kindly suggest

I don't, why you are trying to do this, but you use following: document.querySelector("[onclick=\"loadYearPage('2018-2019')\"]") — Rakesh Makluri, Jan 24 '19 at 07:16
Previously: https://stackoverflow.com/questions/42855587/css-selector-on-onclick-function — Tim Williams, Jan 24 '19 at 07:18
How could i get click on any year on below link using ie.document.queryselector? "https://www.nseindia.com/products/content/derivatives/currency/cd_historical_businessGrowth.htm" — Ashish, Jan 24 '19 at 07:34

QHarr · Accepted Answer · 2019-01-24T17:01:17.407

Tim's answer would be my preference as it escapes nicely. You can also specify multiple css attribute = value selectors with different operators and combine as And syntax

ie.document.querySelector("a[onclick^=loadYearPage][onclick*='2018-2019']")

If either of those substrings only appears once on the page you may be able to reduce this e.g.

ie.document.querySelector("a[onclick*='2018-2019']")

Using your provided page you can indeed use the contains modifier (*) to search by partial string in the value of the onclick attribute. Below is an example where you can pass the year as a variable. I have gone for a shorter selector for greater speed. A slight wait for the element to be present is required. I have used a timed loop.

Option Explicit  
'https://www.nseindia.com/products/content/derivatives/currency/cd_historical_businessGrowth.htm
Public Sub PerformClick()
    Dim ie As InternetExplorer, t As Date, ele As Object
    Const MAX_WAIT_SEC As Long = 10
    Set ie = New InternetExplorer
    Dim yearSelection As String
    yearSelection = "2018-2019"
    With ie
        .Visible = True
        .Navigate2 "https://www.nseindia.com/products/content/derivatives/currency/cd_historical_businessGrowth.htm"

        While .Busy Or .readyState < 4: DoEvents: Wend
        t = Timer
        Do
            On Error Resume Next
            Set ele = .document.querySelector("[onclick*='" & yearSelection & "']")
            On Error GoTo 0
            If Timer - t > MAX_WAIT_SEC Then Exit Do
        Loop While ele Is Nothing
        If Not ele Is Nothing Then
            ele.Click
            While .Busy Or .readyState < 4: DoEvents: Wend
        End If
        'other code
        Stop                                     '<==Delete me later
        .Quit
    End With
End Sub

score 1 · Answer 2 · answered Jan 24 '19 at 07:34

1

This works:

 document.querySelector('a[onclick="loadYearPage(\'2018-2019\')"]')

answered Jan 24 '19 at 07:34

Tim Williams

154,628
8
97
125

Single invited comma in QuerySelector

2 Answers2