how to extract string from in javascript

Question

Given string is like const testString = 'hello people, @ppshein1@gmail.com @ppshein2@gmail.com';

But I want to convert like ['@ppshein1@gmail.com', '@ppshein2@gmail.com'] and do like that:

function getString() {
  const str = 'hello people, @ppshein1@gmail.com @ppshein2@gmail.com';
  var n = str.slice(str.indexOf('@'), str.length);
  var arr = n.split(' ');
  return arr;
}

I feel it's not best practice to develop and no error handling as well. Could you guy suggest me how to improve to meet es6 syntax for above my code and be best practice. Thanks.

will it always have gmail ids? I don't think so.. would there any comma `,` within the email ids part? — Danyal Sandeelo, Jan 24 '19 at 09:09
That looks pretty good to me - just first check that `@` exists and that there is text after it. — CertainPerformance, Jan 24 '19 at 09:09
@DanyalSandeelo seems to be email id, but there is no comma. — PPShein, Jan 24 '19 at 09:19

score 2 · Accepted Answer · answered Jan 24 '19 at 09:10

2

You could look for @ and not whitespace.

var string = 'hello people, @ppshein1@gmail.com @ppshein2@gmail.com';

console.log(string.match(/@\S+/g));

answered Jan 24 '19 at 09:10

Nina Scholz

376,160
25
347
392

how to extract string from in javascript

1 Answers1