Check store open hours - errors with compare a String and an int

Question

I'm attempting to write my first C# script. The script is for opening hours... My if ((weekDay == sunday) && time > openingTime && closingTime < time) line is spitting errors due to:

CS0019 C# Operator '<' cannot be applied to operands of type 'string' and 'int'

After looking at related answers on SO, I still haven't been able to get my code working. I've tried converting the string into an int, this didn't work (unless I did something stupid)

var weekDay = DateTime.Today.DayOfWeek;
var isOpen = "We are open!";
var isClosed = "We are closed";
var sunday = DayOfWeek.Sunday;


var time = DateTime.Now.ToString("hh:mm");

var openingTime = 08;
var closingTime = 16;


if ((weekDay == sunday) && time > openingTime && time < closingTime)
{
    Console.WriteLine(isClosed);
}

Your `time` variable is of type `string` - you cannot compare a `string` to an `int` (which both `openingTime` and `clostingTime` are). — Preston Guillot, Feb 03 '19 at 19:03

Vadim Martynov · Answer 1 · 2019-02-03T19:01:42.360

2

You can use DateTime struct insted of string and use its properties like Hour to retrieve current hour.

var time = DateTime.Now;
if ((time.DayOfWeek == sunday) && time.Hour > openingTime && closingTime < time.Hour)
{
    Console.WriteLine(isClosed);
}

This is a more structured way to solve a problem then convert DateTime to string and then parse the string back to extract current hour.

edited Feb 03 '19 at 19:01

answered Feb 03 '19 at 18:59

Vadim Martynov

8,602
5
31
43

`clsoingTime` is an `int`. `int` does not have a property `Hour`. – Erik Philips Feb 03 '19 at 19:01

score 1 · Accepted Answer · answered Feb 03 '19 at 19:06

1

It seems that you want to evaluate against the current hour. Use the DateTime.Hour property instead, you cannot do the comparison between an int and a string.

var weekDay = DateTime.Today.DayOfWeek;
var isOpen = "We are open!";
var isClosed = "We are closed";
var sunday = DayOfWeek.Sunday;


var time = DateTime.Now.Hour;

var openingTime = 8;
var closingTime = 16;


if ((weekDay == sunday) && time > openingTime && time < closingTime)
{
    Console.WriteLine(isClosed);
}

answered Feb 03 '19 at 19:06

yv989c

1,453
1
14
20

Your answer does stop the error, although the output is now 19. Not "We are closed". Any idea how to tackle that? – Duke Dodson Feb 03 '19 at 19:10
Problem on my end which is solved. This worked, thank you. – Duke Dodson Feb 03 '19 at 19:15
I'm glad it helped. – yv989c Feb 03 '19 at 19:16

Check store open hours - errors with compare a String and an int

2 Answers2