Insert multiple values in MySql Column

Question

I have information from a form that i would like to enter into a MySQL DB, The normal insert works great for me but I would like to combine two text fields into one Column in the database.

Below is the current code I use to insert values to MySQL

$make = $_POST['make'];
$model = $_POST['model'];

UPDATE gs.gs_objects SET
    vin = '".$vin."',
    plate_number = '".$engine."',
    model = '".$make."' '".$model."', //I am not sure if this is correct as it keeps giving me error!!
    installer = '".$installer."'
WHERE imei = '$imei'

I am trying to add the make and model into on Column Ford Ranger as it is in two separate fields in my form

If you run such a query, be sure to check for error messages thrown by MySQL - it will inform you quickly whether that works or not — Nico Haase, Feb 04 '19 at 14:08
Also you should use [prepared Statements](http://php.net/manual/en/intro.pdo.php) — KHansen, Feb 04 '19 at 14:10

score 5 · Accepted Answer · answered Feb 04 '19 at 14:07

You have unwanted single quotes here :

model = '".$make."' '".$model."'

Should be written as :

model = '".$make." ".$model."'

Query :

$query = 
    "UPDATE gs.gs_objects SET
        vin = '".$vin."',
        plate_number = '".$engine."',
        model = '".$make." ".$model."', 
        installer = '".$installer."'
    WHERE imei = '$imei'";

NB : anyone on SO will strongly suggest to use prepared statements and parameterized queries, to protect your code from SQL injection and make your queries more readable and maintainable. Such typo is far much easier to detect when using parameterized queries.

score 2 · Answer 2 · answered Feb 04 '19 at 14:03

The best is to have two different columns (it gives more option if you want to select a specific information). But if you want to keep all the information in one column, you can do it in a variable to avoid concatenation in a query.

$make = $_POST['make'];
$model = $_POST['model'];

$complete_model = $make.' '.$model;

UPDATE gs.gs_objects SET
                vin = '".$vin."',
                plate_number = '".$engine."',
                model = '".$complete_model."',
                installer = '".$installer."'
                WHERE imei = '".$imei."'

Insert multiple values in MySql Column

2 Answers2