How can I sort items correctly using js

Question

I searched problems similar to this one, but those didn't solve my problem. I have a bootstrap cards showing items. And i have a filter to order this cards by liked votes, but when I trigger the js function, the sort doesnt works well (looks like it's ordering in a random way) .

html:

 <a class="like badge" onclick="vote('{% url 'like_item' pk=item.pk %}', '.liked_item_{{item.id}}', '.disliked_item_{{item.id}}', '.like_{{item.id}}', '.dislike_{{item.id}}')" href="javascript:void(0)">
        <span class="liked_item_{{item.id}} liked_votes">
          {{ item.count_likes }}
        </span>
      </a>

js:

if(this.name == 'thumbsUp'){
    var thumbsUpOrderedDivs = $divs.sort(function (a, b) {
        return $(a).find('.liked_votes').text() < $(b).find('.liked_votes').text();
    });
    $("#idea-list-group").html(thumbsUpOrderedDivs);
}

[Your sorting function is not symmetric](https://stackoverflow.com/questions/24080785/sorting-in-javascript-shouldnt-returning-a-boolean-be-enough-for-a-comparison) — VLAZ, Feb 07 '19 at 13:28
Do the curlys `{{ }}` indicate Angular? In which case, or for a similar framework, I would look into a sort or orderBy pipe to do the sorting. — Andy G, Feb 07 '19 at 13:35
Possible duplicate of [Javascript : natural sort of alphanumerical strings](https://stackoverflow.com/questions/2802341/javascript-natural-sort-of-alphanumerical-strings) — Heretic Monkey, Feb 07 '19 at 14:12

score 2 · Accepted Answer · edited Feb 07 '19 at 13:30

2

You should use String.prototype.localeCompare()

localCompare:The localeCompare() method returns a number indicating whether a reference string comes before or after or is the same as the given string in sort order

if(this.name == 'thumbsUp'){
    var thumbsUpOrderedDivs = $divs.sort(function (a, b) {
        return ($(a).find('.liked_votes').text() + '').localeCompare($(b).find('.liked_votes').text());
    });
    $("#idea-list-group").html(thumbsUpOrderedDivs);
}

edited Feb 07 '19 at 13:30

VLAZ

26,331
9
49
67

answered Feb 07 '19 at 12:59

Maheer Ali

35,834
5
42
73

I got `localCompare is not a function`, I'm trying solve it. – mr.abdo Feb 07 '19 at 13:09
1

It's supposed to be local**e**Compare. I have made an edit – VLAZ Feb 07 '19 at 13:30
1

take care with localCompare, in some browsers is not compatible https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare#Browser_compatibility – Álvaro Touzón Feb 07 '19 at 13:37
1

@ÁlvaroTouzón not compatible with expanded usage, the suggested here is fine. – VLAZ Feb 07 '19 at 13:40

Alen.Toma · Answer 2 · 2019-02-07T14:08:36.387

try parsing the text to numbers

    var thumbsUpOrderedDivs = $(".liked_votes").sort(function (a, b) {
        return  parseInt($(a).text()) - parseInt($(b).text());
    });
    
    $(".badge").html(thumbsUpOrderedDivs);

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<a class="like badge">
        <span class="liked_item_{{item.id}} liked_votes">
         5
        </span>
          <span class="liked_item_{{item.id}} liked_votes">
         1
        </span>
        
          <span class="liked_item_{{item.id}} liked_votes">
         3
        </span>
        
          <span class="liked_item_{{item.id}} liked_votes">
         100
        </span>
      </a>

That is still not a symmetric sorting function and would not guarantee correct sorting. — VLAZ, Feb 07 '19 at 13:38

How can I sort items correctly using js

2 Answers2