GetFiles not getting the correct files

Question

I need to get all .txt files in all subfolders of a specified folder so I do:

var files = Directory.GetFiles(reportsFolder, "*.txt", SearchOption.AllDirectories);

However, in some folders I also have files with extensions like .txt_TODO, and these are also being retrieved by GetFiles.

How can I skip these files?

You can get all files and then filter them by regualr expression ".+\.txt$" — Aleks Andreev, Feb 08 '19 at 09:06
Or add .`Where(file => Path.GetExtension(file).Equals(".txt", StringComparison.OrdinalIgnoreCase))` — Dmitry Bychenko, Feb 08 '19 at 09:08
https://blogs.msdn.microsoft.com/oldnewthing/20140313-00/?p=1513 — Falco Alexander, Feb 08 '19 at 09:11

score 0 · Accepted Answer · answered Feb 08 '19 at 09:07

0

Just filter the result by comparing the extension to ".txt", e.g. using LINQ:

var files = Directory.GetFiles(reportsFolder, "*.txt", SearchOption.AllDirectories)
    .Where(f => Path.GetExtension(f).Equals(".txt", StringComparison.OrdinalIgnoreCase))
    .ToArray();

answered Feb 08 '19 at 09:07

Klaus Gütter

11,151
6
31
36

`.EnumerateFiles` instead of `.GetFiles` will be better choice (no premature materialization) in the context – Dmitry Bychenko Feb 08 '19 at 09:09
@DmitryBychenko: Sure; but then also the ToArray() has to be removed... What's better depends on what he is doing with the returned collection. – Klaus Gütter Feb 08 '19 at 09:11
@KlausGütter: Even with final `.ToArray()` switching to `EnumerateFiles` seems to be a better option: the materialized result of `Directory.GetFiles` is immediately lazily enumerated by `Where`, so replacing it with `EnumerateFiles` doesn't change the behaviour if the final `.ToArray()` is left intact. – Vlad Feb 08 '19 at 12:43

GetFiles not getting the correct files

1 Answers1