how to convert object's properties as list elements

Question

I am trying to get all data from DB and display it in a table using ajax and stored procedure.

public List<string> ShowDetailsFromDB()
{
    using (adoHelper = new AdoHelper(connectionString))
    {
        List<string> users = new List<string>();  
        string procedureName = "GetDetails";
        SqlDataReader dataReader = adoHelper.ExecuteDataReaderByProcedure(procedureName);
        while (dataReader.Read())
        {
            User user = new User();
            user.userId = dataReader[1] as string;
            user.password = dataReader[2] as string;
            user.userName = dataReader[3] as string;
            user.address = dataReader[4] as string;
            user.email = dataReader[5] as string;
            user.phone = dataReader[6] as string;

            //here I want to assign each object property as list element

        }
        return users;
    }
}

You need `List users` a list of users. Then add user to list with `users.Add(user)` and you method should return `List` — Renatas M., Feb 12 '19 at 12:35
Use `Reflection` as shown here in a few different ways: https://stackoverflow.com/q/737151/4636715 — vahdet, Feb 12 '19 at 12:41
Please clarify with an example. You have multiple users and each has multiple properties. Do you want all the properties _for each_ user into a string? Or do you want to create a list of list of string, for each user and each property? — John Alexiou, Feb 12 '19 at 13:49

score 1 · Answer 1 · answered Feb 12 '19 at 13:56

Below are two ways to generate a list of strings from the properties of a User instance.

internal class User
{

    public string userId { get; set; }
    public string password { get; set; }
    public string userName { get; set; }
    public string address { get; set; }
    public string email { get; set; }
    public string phone { get; set; }


    public string[] GetProperties()
    {
        return new string[]
        {
            userId,
            password,
            userName,
            address,
            email,
            phone
        };
    }

    static PropertyInfo[] properties = typeof(User).GetProperties();

    public string[] GetPropertiesAuto()
    {
        return properties.Select((prop) => prop.GetValue(this) as string).ToArray();
    }
}

The above can be used in your code quite simply, although you have to return a list of string array to get all the properties for all the users.

    static public List<string[]> ShowDetailsFromDB()
    {
        using (var adoHelper = new AdoHelper(connectionString))
        {
            List<string[]> users = new List<string[]>();
            string procedureName = "GetDetails";
            SqlDataReader dataReader = adoHelper.ExecuteDataReaderByProcedure(procedureName);
            while (dataReader.Read())
            {
                var user = new User
                {
                    userId = dataReader[1] as string,
                    password = dataReader[2] as string,
                    userName = dataReader[3] as string,
                    address = dataReader[4] as string,
                    email = dataReader[5] as string,
                    phone = dataReader[6] as string
                };


                //here I want to assign each object property as list element
                users.Add(user.GetPropertiesAuto());
            }
            return users;
        }
    }

@Reniuz - that would produce all the properties for all the users into a single string. I am not clear that is the intent of the _OP_. — John Alexiou, Feb 12 '19 at 14:21
Ah sorry I thought users is a List of strings. Missed that string array :) — Renatas M., Feb 12 '19 at 15:20

score 0 · Answer 2 · edited Feb 12 '19 at 13:55

0

You can do it easy using a List of Users.

public class User
{
    public string userId { get; set; }
}
public List<User> ShowDetailsFromDB()
{
    using (adoHelper = new AdoHelper(connectionString))
    {
        List<User> users = new List<User>();
        string procedureName = "GetDetails";
        SqlDataReader dataReader = adoHelper.ExecuteDataReaderByProcedure(procedureName);
        while (dataReader.Read())
        {
            User user = new User
            {
                userId = dataReader[1] as string
            };

            users.Add(user);
            //here I want to assign each object property as list element

        }
        return users;
    }
}

Please tell me if it works

edited Feb 12 '19 at 13:55

Mr.Deer

476
6
17

answered Feb 12 '19 at 12:52

João Paulo Amorim

436
2
8

If you're not sure that your suggested code block will work, please check if it works ***before*** posting it. – absoluteAquarian Feb 12 '19 at 17:15
I do know that the code words, what I mean if this code works for the OP, if this is what he wants. – João Paulo Amorim Feb 12 '19 at 17:31

how to convert object's properties as list elements

2 Answers2