Replacing [TD] with in Javascript

Question

I have a return data string from an Oracle process that outputs [TD] and [/TD] rather than <TD> and </TD> to denote an html table cell. I need to translate [TD] to <TD> and [/TD] to <TD> in an element with an ID of unchangedValues using Javascript.

I've Googled and searched on here and this is the closest I've got so far, neither of which work. Any help here would be most gratefully received.

function strReplace() {
    var string = document.getElementById('unchangedValues').innerHTML;
    var res1 = string.replace(/(\[)|(\])/g, function(match, p1, p2) {
  if (p1) return "<";
  if (p2) return ">"
});
}

and I've also tried:

function substituteValues() {

  const str = document.getElementById('unchangedValues').innerHTML;
  const res1 = str.replace(/\[TD\]/g, '\<TD\>');

  document.getElementById('unchangedValues').innerHTML = res1;
}

Thanks

Seems like a basic duplicate: https://stackoverflow.com/questions/1144783/how-to-replace-all-occurrences-of-a-string-in-javascript — isherwood, Feb 14 '19 at 16:14

Wiktor Stribiżew · Answer 1 · 2019-02-14T16:27:03.053

You may use

console.log(
   "[TD] and [/TD]".replace(/\[(\/?TD)]/gi, '<$1>')
)

The /\[(\/?TD)]/gi regex matches

\[ - a [
(\/?TD) - Group 1: / 1 or 0 times and then TD
] - a ] char
/gi - multiple occurrences, case insensitive.

If there may be attributes in TD use

// Assuming values can't contain ] and " are value qualifiers
console.log( '[TD key="value"] and [/TD]'.replace(/\[(\/?TD(?:\s[^\]]*)?)]/gi, '<$1>') );
// Assuming values can contain ] and " or ' are value qualifiers
console.log( '[TD key="va[l]ue here" key2=\'value 2\' auto ] and [/TD]'.replace(/\[(\/?TD(?:\s+\w+(?:=(?:"[^"]*"|'[^']*'|\w+))?)*)\s*]/gi, '<$1>') );

P Varga · Answer 2 · 2019-02-14T16:55:46.643

0

Generic solution for any tag, not just [TD]:

console.log(
  'Lorem [TD FOO="ipsum"] dolor sit [/TD] amet'
  .replace(/\[([^\]]+)\]/g, '<$1>')
);

edited Feb 14 '19 at 16:55

answered Feb 14 '19 at 16:11

P Varga

19,174
12
70
108

1

Why the regexes at all? – isherwood Feb 14 '19 at 16:12
5

@isherwood Because that is how you may replace all occurrences – Wiktor Stribiżew Feb 14 '19 at 16:12
True but the question doesn't mention it can be `[td]` – P Varga Feb 14 '19 at 16:13
In this case the response will always be [TD] but a case sensitive answer would be good also. – enCue Feb 14 '19 at 16:25
1

This is great guys, thanks. I'll get to trying these answers out over the next few hours and feedback then. Great stuff, thanks! – enCue Feb 14 '19 at 16:26
@enCue You might keep getting new answers faster than you can try them – P Varga Feb 14 '19 at 16:29

score 0 · Answer 3 · answered Feb 14 '19 at 16:17

0

How about that with 2 str.replace() only for brackets?

var str = 'John [TD] Smith [/TD]';
var newstr = str.replace(/\[/gi, '<').replace(/]/gi,'>');
console.log(newstr);

answered Feb 14 '19 at 16:17

A l w a y s S u n n y

36,497
8
60
103

Get Off My Lawn · Answer 4 · 2019-02-14T16:57:35.740

If your id is on a table element or even a tr element, and the format is not correct (I don't know since you didn't post the HTML), the browser will move the invalid stuff outside of the table (or closest valid location). You can see that when run, there is no data within the tr and this is making your code attempt to format an empty string then save the empty string back.

console.log(document.getElementById('unchangedValues').innerHTML)

<table id="unchangedValues">
  <tr>
    [TD]Hi[/TD]
    [TD]Hi[/TD]
    [TD]Hi[/TD]
    [TD]Hi[/TD]
  </tr>
</table>

As you can see by the output, the [TD] and [/TD]'s are all gone from the table, however if you inspect the output, the values will have been moved above or below the table automatically by the browser.

To fix the issue, you need have the items within memory. You can then modify the items and then save them into the table.

let str = `[TD]Hi[/TD] 
    [TD]Hi[/TD] 
    [TD]Hi[/TD] 
    [TD]Hi[/TD]`
    
document.querySelector('#unchangedValues tr').innerHTML = str.replace(/\[(\/?TD)\]/g, '<$1>')

<table id="unchangedValues">
  <tr>
  </tr>
</table>

score 0 · Answer 5 · answered Feb 14 '19 at 16:42

0

you can also check an replace with the regExp of Wiktor Stribiżew

if(str.indexOf('[TD]')!==-1 || str.indexOf('[/TD]')!==-1){str = str.replace(/\[(\/?TD)]/gi, '<$1>')}

answered Feb 14 '19 at 16:42

Julian Argañaraz

88
4

Replacing [TD] with in Javascript

5 Answers5