finding the most common string in array fails with 2 elements or equal amounts

Question

I'm using this algorithm to find the most common string in an array the only problem is when an array contains two elements or equals amounts of strings the following method does not work exp: (arr["Test","Test2"]) returns nothing

Arr["Test", "Test", "Test","Test2"]
//Should return "Test"

  _correctName(array) {
 const modeMap = {};

let maxElement = "";
let maxCount = 1;

for (let i = 0; i < array.length; i++) {
  const element = array[i];
  if (modeMap[element] == null)
    modeMap[element] = 1;
  else
    modeMap[element]++;
  if (modeMap[element] > maxCount) {
    maxElement = element;
    maxCount = modeMap[element];
  }
}
 return maxElement;
};

are you trying to get duplicate string from array or common substring? — Naga Sai A, Feb 14 '19 at 17:20
Possible duplicate of [Get the element with the highest occurrence in an array](https://stackoverflow.com/questions/1053843/get-the-element-with-the-highest-occurrence-in-an-array) — Heretic Monkey, Feb 14 '19 at 17:24

Pedro Lima · Accepted Answer · 2019-02-15T10:26:52.443

1

The problem is that you started maxCount with 1.

If each element in your array appears only once, then none of them will overpass the initial 1 value.

Try again with maxCount starting with 0.

edited Feb 15 '19 at 10:26

answered Feb 14 '19 at 17:22

Pedro Lima

1,576
12
21

finding the most common string in array fails with 2 elements or equal amounts

1 Answers1