MVC3 Razor - TextBoxFor() values bound to a view model do not update correctly after returning from Post

Question

My view displays a series of rows in an html table. The rows are ordered by a rank order from the database. One of the columns in the html table is a textbox that will allow the user to modify this rank order. There is an Update submit button at the bottom of the table which will allow the user to save this new order. The problem Im encountering is that the rank order is updated correctly to the database, but when the controller returns back to the view, all data is updated correctly on the screen but the values in the text box are not updated.

Order   |  Data     
================================================
10      |  Item 1
20      |  Item 2
30      |  Item 3

Lets say the user makes the following changes
Order   |  Data
================================================
50      |  Item 1
20      |  Item 2
10      |  Item 3

Now User hits update and what is rendered is:

Order   |  Data
================================================
50      |  Item 3
20      |  Item 2
10      |  Item 1

(Note data was sorted correctly but values of TextBoxFor did not update)

My View Code

@using (Html.BeginForm("UpdateRanks", "MyController")) {
    <table cellpadding="0" cellspacing="0" width="100%">
    @for (int i = 0; i < Model.DbSelections.Count; i++) {
       var item = Model.DbSelections[i];
       <tr>
        <td>
            @Html.TextBoxFor(m => m.DbSelections[i].Rank, new { @class = "NarrowTextBox" })
        </td>
        <td>
            @Model.DbSelections[i].Rank (works!), @item.ItemName<br />
        </td>
       </tr>
    }
    <input type="submit" value="Update" name="updateaction"  class="StandardButton"/>
</table>
}

Controller code:

[HttpPost]
[MultiButton(MatchFormKey = "updateaction", MatchFormValue = "Update")]
public ActionResult UpdateRanks(MyViewModel model) {

    if (ModelState.IsValid) {

        MyRepository myRepo = new MyRepository();
        <!-- saves updated ranks to database - it works -->
        myRepo.UpdateAutoPicks(...);

        <!-- after saved ranks above, now reload data including ranks from database -->
        <!-- debugging shows that data and ranks and ordering is correct->
        model.DbSelections = myRepo.GetItems();

        return View("Index", model);


    } else {
        <!-- blah -->
    }

    return View("Index", model);
}

score 4 · Accepted Answer · edited May 23 '17 at 11:55

4

See if this other Post helps you out.

The one caveat with using this solution is that you'll lose any of the built in features of using TextBoxFor(), such as validation. If this doesn't work you can try doing ModelState.Clear() to clear out the posted values (see here for more details).

edited May 23 '17 at 11:55

Community

1
1

answered Mar 29 '11 at 19:27

Sara

66
6

score 0 · Answer 2 · answered Jun 15 '13 at 18:22

You do not have to clear the whole ModelState, just the one you wish to update... This may reduce unwanted side effects:

As an example, I have a section of code that formats the user's supplied phone number, not just validates it, to the US 10 digit format. This will return the "cleansed" value for this field on:

ModelState["Phone"].Value = new ValueProviderResult(dummyph, dummyph, System.Globalization.CultureInfo.CurrentUICulture);

score 0 · Answer 3 · answered Feb 10 '12 at 16:27

0

I was having the same problem, and ModelState.Clear() in the controller solved this issue. However, I'm not sure whether it's the right thing to do.

answered Feb 10 '12 at 16:27

Gokulnath

1,166
15
29

MVC3 Razor - TextBoxFor() values bound to a view model do not update correctly after returning from Post

3 Answers3