RecyclerView is duplicating items

Question

My recyclerview is duplicating items when I roll it and I'm already calling adapter.notifyDataSetChanged().

So, probably I'm calling data set update at wrong place, but I can't find how it works.

Here is some code:

       RecyclerView packageRecyclerView;
        Intent intent;
        ChecklistAdapter recyclerViewAdapter;
    
        @Override
        protected void onCreate(@Nullable Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_checklist);
    
            intent = getIntent();
            size = intent.getIntExtra("size", 0);
            Log.d(TAG, "onCreate - Qtd Questões: " + size);
    
            packageRecyclerView = findViewById(R.id.package_lst);
    
            LinearLayoutManager recyclerLayoutManager = new LinearLayoutManager(this);
            packageRecyclerView.setLayoutManager(recyclerLayoutManager);
    
            DividerItemDecoration dividerItemDecoration =
                    new DividerItemDecoration(packageRecyclerView.getContext(),
                            recyclerLayoutManager.getOrientation());
            packageRecyclerView.addItemDecoration(dividerItemDecoration);
    
            List<Checklist> modelList = new ArrayList<>();
            recyclerViewAdapter = new ChecklistAdapter(modelList,this);
            modelList = getPackages();
            recyclerViewAdapter = new ChecklistAdapter(modelList,this);
    
    //        recyclerViewAdapter = new ChecklistAdapter(getPackages(),this);
    
            packageRecyclerView.setAdapter(recyclerViewAdapter);
    
    
        }
    
        private List<Checklist> getPackages() {
            List<Checklist> modelList = new ArrayList<>();
            Log.d(TAG, "getPackages: " + size);
            for (int i=0; i<size;i++) {
    
                List<String> priceList = new ArrayList<>();
                priceList.add("Sim");
                priceList.add("Não");
                priceList.add("Não se Aplica");
                modelList.add(new Checklist(intent.getStringExtra("q"+i), priceList));
            }
    
            recyclerViewAdapter.notifyDataSetChanged();
            return modelList;
        }

Here is my adapter:

    public class ChecklistAdapter extends
        RecyclerView.Adapter<ChecklistAdapter.ViewHolder> {

    private List<Checklist> packageList;
    private Context context;

    public ChecklistAdapter(List<Checklist> packageListIn
            , Context ctx) {
        packageList = packageListIn;
        context = ctx;
    }

    @Override
    public int getItemViewType(int position) {
        return super.getItemViewType(position);
    }

    @Override
    public void setHasStableIds(boolean hasStableIds) {
        super.setHasStableIds(hasStableIds);
    }

    @Override
    public long getItemId(int position) {
        return super.getItemId(position);
    }

    @Override
    public ChecklistAdapter.ViewHolder onCreateViewHolder(ViewGroup parent,
                                                                    int viewType) {

        View view = LayoutInflater.from(parent.getContext())
                .inflate(R.layout.rv_checklistlines, parent, false);

        ChecklistAdapter.ViewHolder viewHolder =
                new ChecklistAdapter.ViewHolder(view);
        return viewHolder;
    }


    @Override
    public void onBindViewHolder(@NonNull ViewHolder holder, int position, @NonNull List<Object> payloads) {
        super.onBindViewHolder(holder, position, payloads);
    }

    @Override
    public void onBindViewHolder(ChecklistAdapter.ViewHolder holder,
                                 int position) {
        Checklist packageModel = packageList.get(position);
        holder.packageName.setText(packageModel.getTitle());

        int id = (position+1)*100;
        for(String price : packageModel.getQuestions()){
            RadioButton rb = new RadioButton(ChecklistAdapter.this.context);
            rb.setId(id++);
            rb.setText(price);

            holder.priceGroup.addView(rb);
        }
    }

    @Override
    public int getItemCount() {
        return packageList.size();
    }

    public class ViewHolder extends RecyclerView.ViewHolder {

        public TextView packageName;
        public RadioGroup priceGroup;

        public ViewHolder(View view) {
            super(view);
            packageName = view.findViewById(R.id.package_name);
            priceGroup = view.findViewById(R.id.price_grp);

            priceGroup.setOnCheckedChangeListener(new RadioGroup.OnCheckedChangeListener() {
                @Override
                public void onCheckedChanged(RadioGroup radioGroup, int i) {

                    Toast.makeText(ChecklistAdapter.this.context,
                            "Radio button clicked " + radioGroup.getCheckedRadioButtonId(),
                            Toast.LENGTH_SHORT).show();
                    
                }
            });
        }
    }
}

In the image below you can see that radio buttons are duplicated and there is some extra blank space in all rows. I saw many questions here and in another forums about this, but it's not clear to me where to call this update dataset.

I'm not an advanced Android developer, so if you can explain, it will be easier to me.

EDIT 1

Checklist class:

       import java.util.List;
    
    public class Checklist {
    
        String title;
        List<String> questions;
    
        public Checklist(String title, List<String> questions) {
            this.title = title;
            this.questions = questions;
        }
    
        public String getTitle() {
            return title;
        }
    
        public void setTitle(String title) {
            this.title = title;
        }
    
        public List<String> getQuestions() {
            return questions;
        }
    
        public void setQuestions(List<String> questions) {
            this.questions = questions;
}

EDIT 2

Adapter Code updated

set `priceList` and `modelList`as global, move `modelList.add(new Checklist(intent.getStringExtra("q"+i), priceList));` outside for loop and try — John Joe, Feb 22 '19 at 03:10
@JohnJoe this way I got only one question and only 3 radio buttons. I want all the questions (image 5.10, 5.11, 5.12 and more) with 3 radio buttons for each question. — Alan Godoi, Feb 22 '19 at 03:18
@Alan, You should use this method _recyclerViewAdapter.notifyDataSetChanged();_ after `setAdapter` — ॐ Rakesh Kumar, Feb 22 '19 at 04:04
@Alan Is that repeated only once or multiple times when you scroll? — Zain, Feb 22 '19 at 04:13
@Alan did you make sure to take out the second `recyclerViewAdapter = new ChecklistAdapter(modelList,this);` when trying @Rakesh Kumar suggestion? — COYG, Feb 22 '19 at 04:14
@Alan, You do not need call `recyclerViewAdapter = new ChecklistAdapter(modelList,this);` twice — ॐ Rakesh Kumar, Feb 22 '19 at 04:22
@Alan, Did you check the list size on Adapter `packageList = packageListIn;`?? Are you getting the same??? — ॐ Rakesh Kumar, Feb 22 '19 at 04:32
best solution: https://stackoverflow.com/questions/70385937/recycler-view-with-duplicate-rows-after-refreshing-activity — Rene Garcia FalconDev, Mar 11 '23 at 04:03

score 14 · Answer 1 · edited May 05 '20 at 09:41

14

Use holder.setIsRecyclable(false) in onCreateViewHolder()

It worked for me.

edited May 05 '20 at 09:41

Marcel Bro

4,907
4
43
70

answered Apr 17 '20 at 16:30

Avirup Ghosh

171
1
5

This helped to solve the issue with ViewPager2 and recycler adapter with multiple view types – Vishal Kottarathil May 05 '20 at 08:13
3

This will violate the real use case of recycler view. – pandey_shubham Feb 24 '21 at 14:04

score 13 · Accepted Answer · answered Feb 22 '19 at 05:12

13

I replicated your problem.

adding holder.priceGroup.removeAllViews(); on onBindViewHolder will fix it. Like so:

 @Override
public void onBindViewHolder(ChecklistAdapter.ViewHolder holder,
                             int position) {
    Checklist packageModel = packageList.get(position);
    holder.packageName.setText(packageModel.getTitle());

    int id = (position+1)*100;
    holder.priceGroup.removeAllViews();

    for(String price : packageModel.getQuestions()){
        RadioButton rb = new RadioButton(ChecklistAdapter.this.context);
        rb.setId(id++);
        rb.setText(price);
        holder.priceGroup.addView(rb);
    }
}

You were adding to the view every time without removing the previous views.

answered Feb 22 '19 at 05:12

COYG

1,538
1
16
31

1

Awesome. It works. I also removed setHasStableIds and getItemViewType, maybe it can help someone else. Thx all for your time. – Alan Godoi Feb 22 '19 at 05:19
No bother, I didn't even include them when I copied your code, just used the original. – COYG Feb 22 '19 at 05:20
1

Just realized one more thing, it do not duplicates anymore, but it loses selected radios when I scroll. – Alan Godoi Feb 22 '19 at 05:23
radios you clicked say on question 3? and you scroll down to say question 25, and then return to question 3? and it is unchecked? Is that the problem? – COYG Feb 22 '19 at 05:26
Yes, thats the problem. – Alan Godoi Feb 22 '19 at 05:26
1

i understand actually, the views get destroyed every time you scroll, you will need to store this data and retrieve it when ever you return and set it when you return to the view. – COYG Feb 22 '19 at 05:28
1

See the answers [here](https://stackoverflow.com/questions/32255720/recyclerview-adapter-resets-radio-buttons) – COYG Feb 22 '19 at 05:30
1

One more time helped me. – Alan Godoi Feb 22 '19 at 05:32
1

THANK YOU THANK YOU THANK YOU!!!!. I have similar problem, because i was adding views to parent as recyclerview. The data got duplicated after adding new data / scrolling, now I know why, thanks!!!! – Irfandi D. Vendy Apr 30 '20 at 06:23

score 6 · Answer 3 · edited Jul 12 '20 at 05:17

6

You just need to call list.clear(); before insert into RecyclerViewAdapter. then call after call adapter.notifyDatasetChange()

edited Jul 12 '20 at 05:17

Gk Mohammad Emon

6,084
3
42
42

answered Jul 11 '20 at 14:11

Paras Bhatt

61
1
2

2

Please don't share image of code instead of code snipet. – Gk Mohammad Emon Jul 11 '20 at 15:03

Vasudev Vyas · Answer 4 · 2019-02-22T04:59:13.437

4

you have to setHasStableIds(true) to your Adapter in your activity.

and in your Adapter class you have to set below method. It may help you. it is work for me.

  @Override
    public long getItemId(int position) {
        return position;
    }

    @Override
    public int getItemViewType(int position) {
        return position;
    }


    @Override
    public void setHasStableIds(boolean hasStableIds) {
        super.setHasStableIds(hasStableIds);
    }

you want like this?

edited Feb 22 '19 at 04:59

answered Feb 22 '19 at 04:29

Vasudev Vyas

726
1
10
28

1

it is repeating all items now, not only radios. – Alan Godoi Feb 22 '19 at 04:44
I did it as you said. I want exactly what you show at your picture, but with only 3 radios for each question. With your code its duplicating. – Alan Godoi Feb 22 '19 at 05:09

score 4 · Answer 5 · answered Feb 16 '21 at 20:39

4

Put holder.setIsRecyclable(false) in onBindViewHolder() like below example.

@Override
    public void onBindViewHolder(UsageStatVH holder, int position) {
        holder.bindTo(list.get(position));
        holder.setIsRecyclable(false);
    }

answered Feb 16 '21 at 20:39

donmj

379
7
13

score 1 · Answer 6 · answered Feb 22 '19 at 04:20

1

Please override the below method in ChecklistAdapter

@Override
public long getItemId(int position) {
    return position;
}

And in in your onCreate() add:

recyclerViewAdapter.setHasStableIds(true);

answered Feb 22 '19 at 04:20

Zain

37,492
7
60
84

I got an error: Cannot change whether this adapter has stable IDs while the adapter has registered observers. – Alan Godoi Feb 22 '19 at 04:23
@Alan You must use recyclerViewAdapter.setHasStableIds(true); before packageRecyclerView.setAdapter(recyclerViewAdapter); – Zain Feb 22 '19 at 04:26
@Alan https://stackoverflow.com/questions/52460141/cannot-change-whether-this-adapter-has-stable-ids-while-the-adapter-has-register hope this could help you – Zain Feb 22 '19 at 04:37
It do not duplicate radios anymore, but it is reording items and radios, so I can't get the responses. – Alan Godoi Feb 22 '19 at 04:39
@Alan do you override getItemViewType() in the adapter? – Zain Feb 22 '19 at 04:40
remember you're commenting out the block of code that modifies lastCheckedRadioGroup – Zain Feb 22 '19 at 04:44
you don't need to have getItemViewType() in your adapter since you have only 1 type of items in it; so please remove it – Zain Feb 22 '19 at 04:55
replace return super.getItemId(position); wtih just return position; – Zain Feb 22 '19 at 04:58
With this change, it returned giving me 6 radios. – Alan Godoi Feb 22 '19 at 05:05
@Alan check my new answer. – COYG Feb 22 '19 at 05:15

score 0 · Answer 7 · edited Feb 22 '19 at 02:55

0

It is because you are setting your list three time to adapter,

At this time i can't write whole code, but replace this block in your code it will work.

Try this code,

    DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(packageRecyclerView.getContext(), recyclerLayoutManager.getOrientation()); 
    packageRecyclerView.addItemDecoration(dividerItemDecoration);
    List<Checklist> modelList = new ArrayList<>(); 
    modelList = getPackages(); recyclerViewAdapter = new ChecklistAdapter(modelList,this);  
    packageRecyclerView.setAdapter(recyclerViewAdapter);

And also remove below line from your getPackages() function.

recyclerViewAdapter.notifyDataSetChanged();

edited Feb 22 '19 at 02:55

John Joe

12,412
16
70
135

answered Feb 22 '19 at 02:44

Prayag Gediya

1,078
2
11
20

Still the same thing, when I scroll, items duplicate. – Alan Godoi Feb 22 '19 at 02:51
You are making modelList in for loop, remove it from for loop and add data only once. – Prayag Gediya Feb 22 '19 at 02:54
modelList is created before for loop, I'm just adding items to it inside for loop. – Alan Godoi Feb 22 '19 at 03:01
Yes, that is the problem, you are adding data in loop so you list will contain same data for three time. – Prayag Gediya Feb 22 '19 at 03:06
Take a look at the image, in the loop I'm adding one title (image question) and 3 radio buttons to each question. When I scroll it duplicates to six radio buttons. – Alan Godoi Feb 22 '19 at 03:10

score 0 · Answer 8 · answered Feb 22 '19 at 04:24

Instead of

 List<Checklist> modelList = new ArrayList<>();
    recyclerViewAdapter = new ChecklistAdapter(modelList,this);
    modelList = getPackages();
    recyclerViewAdapter = new ChecklistAdapter(modelList,this);
    packageRecyclerView.setAdapter(recyclerViewAdapter);

Use like this

    recyclerViewAdapter = new ChecklistAdapter(getPackages(),this);
    packageRecyclerView.setAdapter(recyclerViewAdapter);

AND modify your getPackages method like

private List<Checklist> getPackages() {
 List<Checklist> modelList = new ArrayList<>();
 Log.d(TAG, "getPackages: " + size);

for (int i=0; i<size;i++) {
   List<String> priceList = new ArrayList<>();
    priceList.add("Sim");
    priceList.add("Não");
    priceList.add("Não se Aplica");
    modelList.add(new Checklist(intent.getStringExtra("q"+i), priceList));
}
return modelList;
}

Hope this will help you.

@Alan if your item duplicate when you scrolled then it's problem within your **onBindViewHolder** when you add radio button in a radio group. **It's because of every time you scrolled, your onBindViewHolder method call and adding new radio button** — Jakir Hossain, Feb 22 '19 at 04:41
Can you explain more, please? Your answer do not solved the problem. — Alan Godoi, Feb 22 '19 at 04:53

score 0 · Answer 9 · edited Oct 30 '21 at 09:22

Modify your Checklist...

public class Checklist {

    String title;
    List<String> questions;
    boolean isRadioButtonAdded;

    public Checklist(String title, List<String> questions) {
        this.title = title;
        this.questions = questions;
    }
    public boolean getIsAdded(){
        return isRadioButtonAdded;
    }
    
    public void setIsAdded(boolean isAdded){
        this.isRadioButtonAdded = isAdded;
    }

    public String getTitle() {
        return title;
    }

    public void setTitle(String title) {
        this.title = title;
    }

    public List<String> getQuestions() {
        return questions;
    }

    public void setQuestions(List<String> questions) {
        this.questions = questions;
}

And modify your onBindViewHolder

@Override
public void onBindViewHolder(ChecklistAdapter.ViewHolder holder,
                             int position) {
    Checklist packageModel = packageList.get(position);
    holder.packageName.setText(packageModel.getTitle());

    int id = (position+1)*100;
    if(!packageModel.getIsAdded){
        for(String price : packageModel.getQuestions()){
            RadioButton rb = new RadioButton(ChecklistAdapter.this.context);
            rb.setId(id++);
            rb.setText(price);

            holder.priceGroup.addView(rb);
            packageModel.setIsAdded(true)
        }
    }
}

List stills repeating. :( – Alan Godoi Feb 22 '19 at 05:02 — Alan Godoi, Feb 22 '19 at 05:02

score 0 · Answer 10 · answered Aug 08 '23 at 12:30

If you're working with DiffUtils I had same problem making duplicate item while i tried to get list from Room DB then updating Recyclerview

before

private fun getLocalMessage(offset: Int, scrollToEnd: Boolean) {
    vm.getLocalMessage(channelId = channelId, offset = offset) {
        lifecycleScope.launch {
            val job = CoroutineScope(Dispatchers.IO).launch {
                channelMessageDB.addAll(it)
            }
            job.join()
            bindMessagesToRv(messageList = channelMessageDB, enableScrollToEnd = scrollToEnd)
        }
    }
}

private fun bindMessagesToRv(
    message: ChannelMessageEntity.ChannelMessageData? = null,
    messageList: List<ChannelMessageEntity.ChannelMessageData> = emptyList(),
    enableScrollToEnd: Boolean = false
) {
    lifecycleScope.launch {
        if (messageList.isNotEmpty()) {
            val job = CoroutineScope(Dispatchers.IO).launch {
                channelMessage.addAll(messageList)
            }
            job.join()
            channelMessage.sortedBy {
                it.messageTime
            }.apply {
                adapter.addItem(newItem = this)
            }

        }
        message?.let {
            channelMessage.add(it)
            adapter.addItem(newItem = channelMessage)

        }

    }
}

Then I update my localmessage function to this

private fun getLocalMessage(offset: Int, scrollToEnd: Boolean) {
    vm.getLocalMessage(channelId = channelId, offset = offset) {
        lifecycleScope.launch {
            bindMessagesToRv(messageList = it, enableScrollToEnd = scrollToEnd)
        }
    }
}

already I had two list which I pass them , now just one . Might help , GL :)

RecyclerView is duplicating items

10 Answers10

Linked