2

In https://github.com/jimshowalter/architecture-enforcer, I'm trying to solve "Jacoco excludes in the pom aren't working for the pf-CDA classes, possibly due to the shaded jar. Because excludes aren't working, we can't enable the check for 100% statement and branch coverage." The pom seems to have the correct exclude entries, but the build begs to differ, so we had to comment out the thresholds in https://github.com/jimshowalter/architecture-enforcer/blob/master/pom.xml#L93.

Any idea why excludes aren't working?

Jim Showalter
  • 550
  • 3
  • 8
  • 20
  • It works with the excludes as I had them. – Jim Showalter Feb 26 '19 at 20:01
  • After uncommenting mentioned lines build successfully finished. There is no package org.pfsw.* in src folder. Why do you want it to exclude? Am I missing something? – Peter Šály Feb 26 '19 at 18:22
  • The org.pfsw class files wind up in the shaded jar. For some reason the N - 1 iterations I tried on the pom to get the report to exclude those files didn't work. I finally got it working. It's a bit creepy though, because it simply started working. – Jim Showalter Feb 26 '19 at 20:01
  • After N iterations on the pom, finally got it to work. – Jim Showalter Feb 26 '19 at 19:59
  • But how did you made it work? – VonC Feb 26 '19 at 21:49
  • Exactly. When I was trying to get it to work before, I tried everything to exclude the pfsw classes, and nothing worked. Should have taken a screenshot. Then today I read Peter Saly's reply, tried it, and it magically worked. No idea why. I wouldn't have posted the question if it had worked before. – Jim Showalter Feb 26 '19 at 22:33

0 Answers0