3

I've been trying to create an X number of buttons, based on the value of a variable in PyQt5, but my way is not working.

I created a function with a loop, with the X value being the number of buttons.

This code (function is commented) works:

class Ui_MainWindow(object):

def setupUi(self, MainWindow):

    def createButtons(x):
        number_of_buttons = x
        table_set = 1
        distance_from_left = 5

        while table_set <= number_of_buttons:
            print(distance_from_left) #Check if the loop is runnig
            "self.pushButton_{} = QtWidgets.QPushButton(self.groupBox)".format(table_set)
            "self.pushButton_{}.setGeometry(QtCore.QRect({}, 15, 40, 35))".format(table_set, distance_from_left)
            "self.pushButton_{}.setText(\"{}\")".format(table_set, str(table_set).zfill(2))
            "self.pushButton_{}.setObjectName(\"pushButton_{}\")".format(table_set, table_set)
            table_set += 1
            distance_from_left += 45

    MainWindow.setObjectName("MainWindow")
    MainWindow.resize(1366, 768)
    MainWindow.setAutoFillBackground(False)
    self.centralwidget = QtWidgets.QWidget(MainWindow)
    self.centralwidget.setObjectName("centralwidget")
    self.groupBox = QtWidgets.QGroupBox(self.centralwidget)
    self.groupBox.setGeometry(QtCore.QRect(0, 80, 531, 56))
    self.groupBox.setAutoFillBackground(False)
    self.groupBox.setObjectName("groupBox")
    #createButtons(3)
    self.pushButton_1 = QtWidgets.QPushButton(self.groupBox)
    self.pushButton_1.setGeometry(QtCore.QRect(5, 15, 40, 35))
    self.pushButton_1.setText("01")
    self.pushButton_1.setObjectName("pushButton_1")
    self.pushButton_2 = QtWidgets.QPushButton(self.groupBox)
    self.pushButton_2.setGeometry(QtCore.QRect(50, 15, 40, 35))
    self.pushButton_2.setText("02")
    self.pushButton_2.setObjectName("pushButton_2")
    self.pushButton_3 = QtWidgets.QPushButton(self.groupBox)
    self.pushButton_3.setGeometry(QtCore.QRect(95, 15, 40, 35))
    self.pushButton_3.setText("03")
    self.pushButton_3.setObjectName("pushButton_3")
    MainWindow.setCentralWidget(self.centralwidget)
    self.centralwidget.show()
    QtCore.QMetaObject.connectSlotsByName(MainWindow)

This (function is running, direct commands are commented) doesn't work. To my eyes, they look the same.

from PyQt5 import QtCore, QtGui, QtWidgets

class Ui_MainWindow(object):

    def setupUi(self, MainWindow):

        def createButtons(x):
            number_of_buttons = x
            table_set = 1
            distance_from_left = 5

            while table_set <= number_of_buttons:
                print(distance_from_left) #Check if the loop is runnig
                "self.pushButton_{} = QtWidgets.QPushButton(self.groupBox)".format(table_set)
                "self.pushButton_{}.setGeometry(QtCore.QRect({}, 15, 40, 35))".format(table_set, distance_from_left)
                "self.pushButton_{}.setText(\"{}\")".format(table_set, str(table_set).zfill(2))
                "self.pushButton_{}.setObjectName(\"pushButton_{}\")".format(table_set, table_set)
                table_set += 1
                distance_from_left += 45

        MainWindow.setObjectName("MainWindow")
        MainWindow.resize(1366, 768)
        MainWindow.setAutoFillBackground(False)
        self.centralwidget = QtWidgets.QWidget(MainWindow)
        self.centralwidget.setObjectName("centralwidget")
        self.groupBox = QtWidgets.QGroupBox(self.centralwidget)
        self.groupBox.setGeometry(QtCore.QRect(0, 80, 531, 56))
        self.groupBox.setAutoFillBackground(False)
        self.groupBox.setObjectName("groupBox")
        createButtons(3)
        """
        self.pushButton_1 = QtWidgets.QPushButton(self.groupBox)
        self.pushButton_1.setGeometry(QtCore.QRect(5, 15, 40, 35))
        self.pushButton_1.setText("01")
        self.pushButton_1.setObjectName("pushButton_1")
        self.pushButton_2 = QtWidgets.QPushButton(self.groupBox)
        self.pushButton_2.setGeometry(QtCore.QRect(50, 15, 40, 35))
        self.pushButton_2.setText("02")
        self.pushButton_2.setObjectName("pushButton_2")
        self.pushButton_3 = QtWidgets.QPushButton(self.groupBox)
        self.pushButton_3.setGeometry(QtCore.QRect(95, 15, 40, 35))
        self.pushButton_3.setText("03")
        self.pushButton_3.setObjectName("pushButton_3")
        """
        MainWindow.setCentralWidget(self.centralwidget)
        self.centralwidget.show()
        QtCore.QMetaObject.connectSlotsByName(MainWindow)

None of the buttons show up. Can somebody please tell me what I'm doing wrong?

f.poletto
  • 33
  • 1
  • 6
  • 1
    formatting strings won't run your code... – Netwave Feb 28 '19 at 13:48
  • Related reading: [How do I create a variable number of variables?](https://stackoverflow.com/q/1373164/953482) – Kevin Feb 28 '19 at 13:49
  • @Netwave Sorry, what? Your answer was so brief it seems I'm making some really basic mistake. Maybe because I´m really a beginner, I still don´t get it. – f.poletto Feb 28 '19 at 13:55
  • @f.poletto, `"self.pushButton_{} = QtWidgets.QPushButton(self.groupBox)".format(table_set)` this code does literally nothing in there. Ill give you a hint, but I have no time for a full answer: `setAttr(self, "pushButton_{}".format(table_set), QtWidgets.QPushButton(self.groupBox))` – Netwave Feb 28 '19 at 15:27

1 Answers1

5

Try it:

import sys
from PyQt5.QtWidgets import (QMainWindow, QWidget, QVBoxLayout, 
                             QApplication, QPushButton)


class MainWindow(QMainWindow): 
    def __init__(self, x):                                         # x <-- 3
        super().__init__()

        self.centralwidget = QWidget()
        self.setCentralWidget(self.centralwidget)
        self.lay = QVBoxLayout(self.centralwidget)

        for i in range(x):                                          # <---
            self.btn = QPushButton('Button {}'.format(i +1), self)            
            text = self.btn.text()
            self.btn.clicked.connect(lambda ch, text=text : print("\nclicked--> {}".format(text)))
            self.lay.addWidget(self.btn)

        self.numButton = 4

        pybutton = QPushButton('Create a button', self)
        pybutton.clicked.connect(self.clickMethod)

        self.lay.addWidget(pybutton)
        self.lay.addStretch(1)

    def clickMethod(self):
        newBtn = QPushButton('New Button{}'.format(self.numButton), self)
        self.numButton += 1
        newBtn.clicked.connect(lambda : print("\nclicked===>> {}".format(newBtn.text())))
        self.lay.addWidget(newBtn)


if __name__ == "__main__":
    app = QApplication(sys.argv)
    mainWin = MainWindow(3)                                            # 3 --> x
    mainWin.show()
    sys.exit( app.exec_() )

enter image description here

S. Nick
  • 12,879
  • 8
  • 25
  • 33
  • Your code works great, but I still had absolutely no idea why... Anyway, this version of mine works fine: `x = 5 d = 5 for i in range(x): self.pushButton = QtWidgets.QPushButton('Button {}'.format(str(i).zfill(2)), self.groupBox) self.pushButton.setGeometry(QtCore.QRect(int("{}".format(d)), 15, 40, 35)) self.pushButton.setText("{}".format(str(i).zfill(2))) self.pushButton.setObjectName("pushButton_{}".format(str(i).zfill(2))) i += 1 d += 45` Thank you very much. – f.poletto Mar 01 '19 at 14:15
  • Upvoted for your answer. But, why do you need `lambda ch` ? – Scott Oct 29 '21 at 14:16