Factorial with recursion

Question

#include <stdio.h>
long int fact(int n);

int main()
{
    int n;
    printf("Enter number\n");
    scanf("%d",&n);
  printf("Factorial:%ld\n",fact(n));
    return 0;
}


long int fact(int n)
 {
   if(n!=1)
   return n*fact(n-1);

    }

I'm trying to get the factorial of a number with recursion.But I'm getting 0 as the result everytime. What's wrong with this code?

Remember to compile with all warnings on. If there are warnings think about why they're there. — Federico klez Culloca, Mar 02 '19 at 23:10
@FedericoklezCulloca the thing is that the same question was asked couple months ago or so, and the same exact question and the same exact solution. — , Mar 02 '19 at 23:17
@Gox The question in the linked post is a completely separate issue in a different language. There's nothing alike between the two. — Carcigenicate, Mar 03 '19 at 00:25
@Carcigenicate I just realized I deleted the post, but believe me there was exact same question couple weeks ago :( — , Mar 03 '19 at 00:37
Possible duplicate of [Factorial Recursive](https://stackoverflow.com/questions/49223362/factorial-recursive) — aaaaaa123456789, Mar 03 '19 at 07:43
@MarkRotteveel My bad; flag withdrawn. EDIT: s/flag/vote... maybe I shouldn't be doing this late at night. — aaaaaa123456789, Mar 03 '19 at 07:49

score -1 · Answer 1 · answered Mar 02 '19 at 23:08

-1

long int fact(int n)
{
    return n==1? 1 : n*fact(n-1);
}

answered Mar 02 '19 at 23:08

abelenky

63,815
23
109
159

`n` should be probably be `unsigned`, don't you think? – Mike Borkland Mar 02 '19 at 23:14

Factorial with recursion

1 Answers1