Multiple select not inserting selected options to database

Question

This is PHP.

<?php
include 'connect.php';

if (isset($_POST['add'])) {
    $id = 'NULL';
    $Branch = $_POST['Branch'];
    $check = mysqli_query($connect, "SELECT * FROM staff WHERE id='$id'");
    if (0 == mysqli_num_rows($check)) {
        if (1 == 1) {
            $insert = mysqli_query($connect, "INSERT INTO staff(Branch) VALUES('$Branch')") or die(mysqli_error($connect));
            if ($insert) {
                echo '<div class="alert alert-success alert-dismissable"><button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>Data Successfully Saved.</div>';
            } else {
                echo '<div class="alert alert-danger alert-dismissable"><button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>OOps, Data Failed to Save!</div>';
            }
        } else {
            echo '<div class="alert alert-danger alert-dismissable"><button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>Not the same password!</div>';
        }
    } else {
        echo '<div class="alert alert-danger alert-dismissable"><button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>ID already exists!</div>';
    }
}
?>

This is my mysql column.

Branch  text    utf8_general_ci     No  None

This is select element from my form.

<form action="" method="post">
     <select class="selectpicker form-control" multiple data-live-search="true" name="Branch" required="true">
        <option selected>example 1</option>
        <option value="example 2">example 2</option>
        <option value="example 3">example 3</option>
        <option value="example 4">example 4</option>
      </select>
</form>

My problem is next, if i choose one option its indexing database without any problem. if i choose more then one option, last selected option is indexing. So what i want is if i select 2 option for example "example 1, example 2" this both should be index as text in my mysql.

P.S. I know that i am noob and non English speaker but please support me.

Could you please add some PHP code? And what exactly do you want to insert into the column 'Branch'? A text like "example 1, example 2"? — pmatsumura, Mar 10 '19 at 09:21

Barmar · Answer 1 · 2019-03-10T10:13:37.133

0

You need to give it an array-style name, name="Branch[]". Then $_POST['Branch'] will be an array containing all the selected values, and you can insert all the values from it in a loop.

if (isset($_POST['Branch'])) {
    foreach ($_POST['Branch'] as $branch) {
        // insert $branch into the database
    }
}

If you want to insert a comma-delimited string you can use implode:

$branches = implode(',', $_POST['Branch']);

But it's geneally poor database design to put multiple items in a single column. See Is storing a delimited list in a database column really that bad?

Also, in the HTML, required="true" should be either required or required="required". Boolean attributes don't use true/false values; they either have no value, the value is the same as the attribute name, or they're omitted.

edited Mar 10 '19 at 10:13

answered Mar 10 '19 at 09:24

Barmar

741,623
53
500
612

I try this one but nothing changed, its indexing text "Array" – ლევან საყვარელიძე Mar 10 '19 at 09:27
I mean exactly "Array" text is indexing in db. – ლევან საყვარელიძე Mar 10 '19 at 09:34
That means you're not looping over the array. If you try to use an array as a string, it becomes the word `Array`. – Barmar Mar 10 '19 at 10:07
I thought it would be clear when I said "you can insert all the values from it in a loop", but I've added example code to make it clearer. – Barmar Mar 10 '19 at 10:08

score 0 · Answer 2 · answered Mar 10 '19 at 09:36

0

The name of the <select> element should be Branch[]. In your PHP script you'll need to get the value with $branches = implode(',', $_POST['Branch']); before inserting $branches into the database.

answered Mar 10 '19 at 09:36

pmatsumura

391
1
6

Arsee · Accepted Answer · 2019-03-10T09:49:42.503

0

First of all, change attribute name like this name="Branch[]"

next, use foreach loop and retrieve the value one by one

$branches = $_POST['Branch']; //get values in array

$insert_string = ''; //we need to concat array values into this empty variable

use foreach loop

foreach($branches as $branch){
   $insert_string .= $branch . ", "; //set values with comma separater
}

//insert
$insert = mysqli_query($connect, "INSERT INTO staff(Branch) VALUES('$insert_string')") or 
             die (mysqli_error($connect));

edited Mar 10 '19 at 09:49

answered Mar 10 '19 at 09:40

Arsee

283
5
20

He/She doesn't want to insert multiple records, but instead insert one record with a concatenated string. – pmatsumura Mar 10 '19 at 09:44
You are Genius, Thank you my mate – ლევან საყვარელიძე Mar 10 '19 at 09:52
1

Instead of using a foreach loop to concatenate a string, you could use `implode()`, which doesn't add an extra comma to the end. See my answer. – pmatsumura Mar 10 '19 at 09:56

Multiple select not inserting selected options to database

3 Answers3