getter function name 'doEmptyItemsExist'

Asked Mar 18 '19 at 15:54

Active Mar 18 '19 at 15:54

Viewed 45 times

I am a Japanese web developer.

I am not good at English , but I want to be better.

I am making a task application, and I made a function like this in order to check if there are empty entry.

private get doEmptyItemsExist(): boolean {
    return this.title === '' || this.detail === '' || this.deadLine === ''
}

I use this for validate.

'doEmptyItemsExist'

Is this proper English?

And is this proper name for this function?

Is it better to say just 'emptyItemsExist'?

I thought if it starts with 'do', it can tells you that it returns boolean simply.

And I want to know 'emptyItemsExist' or 'emptyItemExists' which is better.

And I want to know proper word for 'item', like I thought maybe it's better to say 'entry'.

Someone, please help me.

asked Mar 18 '19 at 15:54

Kuru

1,417
2
13
20

this maybe off-topic for stackoverflow since this is language question... (besides coding style. but also I'm not sure coding style is on topic) – apple apple Mar 18 '19 at 15:55
an personally I won't start with verb in getter, it just weird to me. – apple apple Mar 18 '19 at 15:58
should name as isNullOrEmpty – Hien Nguyen Mar 18 '19 at 15:59
Thank you so much! So, is 'emptyItemsExist' better? – Kuru Mar 18 '19 at 15:59
@HienNguyen I'm somewhat sure it's not the case. – apple apple Mar 18 '19 at 15:59
I think the same as user 'apple apple'. Anycase, I thing your code on english is wellwritten :) . I would say 'entry' maybe for parameters and item for more generic concepts, usually in arrays or lists. – Mr.Deer Mar 18 '19 at 16:00
I would use `emptyItemExist`, but it's just my style. – apple apple Mar 18 '19 at 16:01
apple apple , you said it's off topic, but you are kind, thank you. I won't use 'do' then. – Kuru Mar 18 '19 at 16:03
Jesús Narváez Tamés, you are write. I see word 'item' often for item in array. – Kuru Mar 18 '19 at 16:04
Hien Nguyen thank you. I see, but if you say 'is', it is write when entry is only one. I want to check if empty entry exist in all entries. – Kuru Mar 18 '19 at 16:08
This is really more a naming convention question which is kind of opinion-based. However, your question is very similar to this one: [Boolean method naming readability](https://stackoverflow.com/q/1566745/691711). – zero298 Mar 18 '19 at 16:09
1

A bit more concise: `isEmpty()`. – Wex Mar 18 '19 at 16:09
zero298 thank you. Oh, I see. So in this case, it is better not to start with 'do'. – Kuru Mar 18 '19 at 16:12
Wex thank you. I see, but it is like checking only one entry. I want to check if empty entry exist in all entries. – Kuru Mar 18 '19 at 16:13
What about `hasEmptyItem`? – ttulka Mar 18 '19 at 16:14
ttulka thank you. Thant is a good name. But this class has more information not only about form. There are function like deleteTask too. – Kuru Mar 18 '19 at 16:18
@akao although depends on the real use case , I guess maybe `valid` is a good name. – apple apple Mar 18 '19 at 16:23
apple apple thank you. Then, how about 'areEntriesValid' or 'areAllEntriesValid'? – Kuru Mar 18 '19 at 16:25

getter function name 'doEmptyItemsExist'

0 Answers0