In an if/else if statement, the variable is being locked into the first option. How can I fix this?

Question

This is my general code (in JavaScript):

let x = Math.floor(Math.random()×6)+1);

if (x=1){
   do this
} else if (x=2){
   do that
} else if.... and so on.

Whenever I test this code in a browser, only actions that could happen in the {do this} section happen. x is being locked as 1, even though it is meant to be a fair 6 sided die. Any ideas why this is happening, and how I can fix it?

you set x equal to 1 each time. 1 is truthy, so it passes the first conditional via the leaky assignment evaluating out to 1. — dandavis, Mar 29 '19 at 18:22
wouldn't that eliminate the ability for it to be variable, though? does that not just lock x in as 1? — DylanK25 _, Mar 29 '19 at 18:24
Just checking, are you using `×` on the first line, or `*`? — Chris Forrence, Mar 29 '19 at 18:26
@DylanK25_ Welcome to StackOverflow, please go through the rules and format for **asking or answering** here. https://stackoverflow.com/help — Mukul Kumar, Mar 29 '19 at 18:29

score 2 · Answer 1 · answered Mar 29 '19 at 18:23

2

The = operator in JavaScript is for assignment. x=1 will always return true because that is an assignment that will never fail. To test for equality use == (equality with conversion) or === (strict equality).

answered Mar 29 '19 at 18:23

Scott Marcus

64,069
6
49
71

score 0 · Answer 2 · answered Mar 29 '19 at 18:32

0

You have your if (x=1) assigning the value of 1 to x, rather than checking if it's equal to it. This results in it always returning TRUE. Using a pair of == (or ===) will solve this.

answered Mar 29 '19 at 18:32

Nathan

31
5

In an if/else if statement, the variable is being locked into the first option. How can I fix this?

2 Answers2

Linked

Related