PHP does return from file_get_contents when using url, but not when url is loaded from array

Question

I'm trying to return image from URL (from Reddit). The URLs are stored in array $out:

Array ( 
[0] => https://preview.redd.it/pvloz4h9whp21.jpg?width=216&crop=smart&auto=webp&s=983c6b25740ed0389f8077e25d9ade75ae967b81 
[1] => https://preview.redd.it/15syi021vhp21.jpg?width=216&crop=smart&auto=webp&s=b2bff216f7164084026ad25a11bc4a07f8f88e32 
[2] => https://preview.redd.it/rz8xy4csrhp21.jpg?width=216&crop=smart&auto=webp&s=8a1b4d5ac04958399a184dcbc2045bcb33b559a1 
)

When I put get_file_contents from original url it works and returns image.

$image = file_get_contents('https://preview.redd.it/pvloz4h9whp21.jpg?width=216&crop=smart&auto=webp&s=983c6b25740ed0389f8077e25d9ade75ae967b81');

header('Content-type: image/jpeg');
echo $image;

But when I get the URL from array it returns blank page.

$image = file_get_contents($out[0]);

header('Content-type: image/jpeg');
echo $image;

I get $out by this rather unclear mess:

$posts = json_decode(file_get_contents('http://www.reddit.com/r/creepyasterisks/new.json?sort=new&limit=5', true), true)['data']['children'];
$out = array();
foreach($posts as $post){
  $post = json_encode($post, JSON_PRETTY_PRINT);
  $post = json_decode($post);
  $post = $post->data->preview->images;
  $post = json_encode($post, JSON_PRETTY_PRINT);
  $post = substr($post, 1, -1);
  $post = json_decode($post);
  $post = $post->resolutions[1]->url;
  array_push($out, $post);
}
print_r($out);

$posts from Reddit API looks something like this:

Try printing out { $out[0] } and comparing it to what you think it's supposed to be. If all else fails, try doing: { $url = $out[0]; $image = file_get_contents($url); } — UncaAlby, Mar 31 '19 at 22:06
before you try to get image with the array put the line of code `var_export($out);` and edit your question and add the output from `var_export($out);` — Jimmix, Mar 31 '19 at 22:39
@UncaAlby I've already tried both of these. When I echoed $out[0] and literally copypasted it into file_get_contents it worked. I've also tried setting it as another variable. — Jakub Harabiš, Mar 31 '19 at 23:42
@Jimmix After adding that into code I always get this: https://ctrlv.cz/9HJm — Jakub Harabiš, Mar 31 '19 at 23:46
@JakubHarabiš Why in the world are you hacking at the json string with `substr($post, 1, -1);` This is a major redflag for me. As are all of those `json_encode()` and `json_decode()` calls -- none of those should be necessary. Show us `$post` before you start manipulating it. `var_export($posts);` — mickmackusa, Apr 01 '19 at 04:00
@mickmackusa I know, that it it really dumb way to get into it, I was trying to decode it myself, but the $post is mix of arrays and objects. I'll add it into original post. That's probably whole problem... — Jakub Harabiš, Apr 01 '19 at 14:49
If the api is delivering urls without html entities encoded, then the urls are html encoded after you "process" the data, then clearly your string manipulations are to blame. Rather than to add another string manipulation, better programming practices would suggest that you investigate the earliest point of breakage and remove all unnecessary actions. — mickmackusa, Apr 01 '19 at 20:37
When you want to post array data on Stackoverflow so that volunteers can use it, generate the display data with `var_export()` -- `print_r()` means volunteers will have to overhaul the format before being able to use it in their test environment. — mickmackusa, Apr 01 '19 at 20:50

MARI Mathieu · Accepted Answer · 2019-04-01T00:21:31.760

I have understand your problem.
Its the code amp; in the url which is a problem

Try this code

<?php
$out = [
    0=>'https://preview.redd.it/jl9xhifkbjp21.jpg?width=216&amp;crop=smart&amp;auto=webp&amp;s=d39e483499249c3863941b4355f37ebff24d4c05',
    1=>'https://preview.redd.it/ak1dcvubgjp21.jpg?width=216&amp;crop=smart&amp;auto=webp&amp;s=aa7f553643a8b0096d0a6d22a3e1440054955d11',
    2=>'https://preview.redd.it/dzx1483qbjp21.jpg?width=216&amp;crop=smart&amp;auto=webp&amp;s=bd53992f74a2a26a89e871e146338a9f4c7a446f',
];

$formateOut = str_replace("amp;", "", $out[0]);

$image = file_get_contents($formateOut);

header('Content-type: image/jpeg');
echo $image; 
?>

score 0 · Answer 2 · answered Mar 31 '19 at 22:02

0

Try this code:

<?php
$out = [
    0=>"https://preview.redd.it/pvloz4h9whp21.jpg?width=216&crop=smart&auto=webp&s=983c6b25740ed0389f8077e25d9ade75ae967b81",
    1=>"https://preview.redd.it/15syi021vhp21.jpg?width=216&crop=smart&auto=webp&s=b2bff216f7164084026ad25a11bc4a07f8f88e32",
    2=>"https://preview.redd.it/rz8xy4csrhp21.jpg?width=216&crop=smart&auto=webp&s=8a1b4d5ac04958399a184dcbc2045bcb33b559a1",
];

$image = file_get_contents($out[0]);

header('Content-type: image/jpeg');
echo $image; 
?>

answered Mar 31 '19 at 22:02

MARI Mathieu

39
1
8

The {0=>} {1=>} and {2=>} should not be necessary, as those are the default keys. Otherwise, there's nothing different from what the OP is doing. – UncaAlby Mar 31 '19 at 22:04
Yes i know but its for your example ;) – MARI Mathieu Mar 31 '19 at 22:05
Oh, Your array works. My array $out is from Reddits JSON API. I just push URLs from API into it. I'm starting to think, that it is some kind of maybe coding/character parsing error? It seems like when URLs are hardcoded, they work, but when they are directly from API they don't work... – Jakub Harabiš Mar 31 '19 at 23:24
This API return this array ?: Array ( [0] => https://preview.redd.it/pvloz4h9whp21.jpg?width=216&crop=smart&auto=webp&s=983c6b25740ed0389f8077e25d9ade75ae967b81 [1] => https://preview.redd.it/15syi021vhp21.jpg?width=216&crop=smart&auto=webp&s=b2bff216f7164084026ad25a11bc4a07f8f88e32 [2] => https://preview.redd.it/rz8xy4csrhp21.jpg?width=216&crop=smart&auto=webp&s=8a1b4d5ac04958399a184dcbc2045bcb33b559a1 ) – MARI Mathieu Mar 31 '19 at 23:29
You have the link of your JSON API so that I see the problem ? – MARI Mathieu Mar 31 '19 at 23:34
I've added code getting data from API into main post. – Jakub Harabiš Mar 31 '19 at 23:39
"Try this" answers are low-value on StackOverflow because they do a poor job of educating/empowering thousands of future researchers. – mickmackusa Apr 01 '19 at 03:53

PHP does return from file_get_contents when using url, but not when url is loaded from array

2 Answers2