flutter: Unhandled Exception: Bad state: Cannot add new events after calling close

Question

I am trying to use the bloc pattern to manage data from an API and show them in my widget. I am able to fetch data from API and process it and show it, but I am using a bottom navigation bar and when I change tab and go to my previous tab, it returns this error:

Unhandled Exception: Bad state: Cannot add new events after calling close.

I know it is because I am closing the stream and then trying to add to it, but I do not know how to fix it because not disposing the publishsubject will result in memory leak. here is my Ui code:

class CategoryPage extends StatefulWidget {
  @override
  _CategoryPageState createState() => _CategoryPageState();
}

class _CategoryPageState extends State<CategoryPage> {
  @override
  void initState() {
    serviceBloc.getAllServices();
    super.initState();
  }

  @override
  void dispose() {
    serviceBloc.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return StreamBuilder(
      stream: serviceBloc.allServices,
      builder: (context, AsyncSnapshot<ServiceModel> snapshot) {
        if (snapshot.hasData) {
          return _homeBody(context, snapshot);
        }
        if (snapshot.hasError) {
          return Center(
            child: Text('Failed to load data'),
          );
        }
        return CircularProgressIndicator();
      },
    );
  }
}

_homeBody(BuildContext context, AsyncSnapshot<ServiceModel> snapshot) {
  return Stack(
      Padding(
          padding: EdgeInsets.only(top: screenAwareSize(400, context)),
          child: _buildCategories(context, snapshot))
    ],
  );
}

_buildCategories(BuildContext context, AsyncSnapshot<ServiceModel> snapshot) {
  return Padding(
    padding: EdgeInsets.symmetric(vertical: 20),
    child: GridView.builder(
      gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
          crossAxisCount: 3, crossAxisSpacing: 3.0),
      itemCount: snapshot.data.result.length,
      itemBuilder: (BuildContext context, int index) {
        return InkWell(
          child: CategoryWidget(
            title: snapshot.data.result[index].name,
            icon: Icons.phone_iphone,
          ),
          onTap: () {},
        );
      },
    ),
  );
}

here is my bloc code:

class ServiceBloc extends MainBloc {
  final _repo = new Repo();
  final PublishSubject<ServiceModel> _serviceController =
      new PublishSubject<ServiceModel>();
  Observable<ServiceModel> get allServices => _serviceController.stream;
  getAllServices() async {
    appIsLoading();
    ServiceModel movieItem = await _repo.getAllServices();
    _serviceController.sink.add(movieItem);
    appIsNotLoading();
  }

  void dispose() {
    _serviceController.close();
  }
}

ServiceBloc serviceBloc = new ServiceBloc();

I did not include the repo and API code because it is not in the subject of this error.

score 38 · Answer 1 · edited Jun 20 '20 at 09:12

38

Use StreamController.isClosed to check if the controller is closed or not, if not closed add data to it.

if (!_controller.isClosed) 
  _controller.sink.add(...); // safe to add data as _controller isn't closed yet

From Docs:

Whether the stream controller is closed for adding more events.

The controller becomes closed by calling the close method. New events cannot be added, by calling add or addError, to a closed controller.

If the controller is closed, the "done" event might not have been delivered yet, but it has been scheduled, and it is too late to add more events.

edited Jun 20 '20 at 09:12

Community

1
1

answered Oct 02 '19 at 04:24

CopsOnRoad

237,138
77
654
440

2

This solution is much better without creating any variables. This example has helped me a lot. – DomingoMG Mar 13 '20 at 22:06
7

Shouldn't framework handle this itself instead throwing error? – Rahul Dange May 12 '20 at 10:46

score 22 · Accepted Answer · answered Apr 05 '19 at 15:06

If the error is actually caused by the code you posted, I'd just add a check to ensure no new events are added after dispose() was called.

class ServiceBloc extends MainBloc {
  final _repo = new Repo();
  final PublishSubject<ServiceModel> _serviceController =
      new PublishSubject<ServiceModel>();
  Observable<ServiceModel> get allServices => _serviceController.stream;
  getAllServices() async {
    // do nothing if already disposed
    if(_isDisposed) {
      return;
    }
    appIsLoading();
    ServiceModel movieItem = await _repo.getAllServices();
    _serviceController.sink.add(movieItem);
    appIsNotLoading();
  }

  bool _isDisposed = false;
  void dispose() {
    _serviceController.close();
    _isDisposed = true;
  }
}

ServiceBloc serviceBloc = new ServiceBloc();

score 4 · Answer 3 · answered Jun 12 '22 at 19:25

You should not worry about memory leak while using flutter_bloc as When using bloc you do not need to close the bloc manually, if you have used a bloc provider to inject the bloc. Bloc Providers handle that for you out of the box as mentioned in the flutter_bloc docs.

BlocProvider is responsible for creating the bloc, it will automatically handle closing the bloc

You can test this in your application. Try printing on the close() override of bloc.

If the Screen at which the bloc was provided is removed from navigation stack then the close() method for that given bloc is called out of the box.

score 3 · Answer 4 · answered Jan 06 '20 at 18:27

I run into same error and noticed that if you check isClosed, the screen is not updated. In your code you have to remove the last line from Bloc file:

ServiceBloc serviceBloc = new ServiceBloc();

and put this line in CategoryPage just before the initState(). This way your widget is creating and disposing the bloc. Before, the widget only disposes the bloc but it is never re-created when the widget is re-created.

score 3 · Answer 5 · answered May 11 '20 at 19:09

3

besides the provided solution I think you should also drain the stream allServices used in your ServiceBloc with:

@override
void dispose() {
      ...
      allServices?.drain(); 
}

answered May 11 '20 at 19:09

Julian2611

422
3
11

score 3 · Answer 6 · answered Aug 13 '22 at 15:48

Check if the bloc/cubit is closed by isClosed variable. Wrap this if conditions to those states which are throwing exception.

Example code

class LandingCubit extends Cubit<LandingState> {
  LandingCubit(this.repository) : super(LandingInitial());
  final CoreRepository repository;

  // Fetches image urls that needs to shown in landing page
  void getLandingImages() async {
    emit(LandingImagesLoading());
    try {
      List<File> landingImages = await repository.landingImages();
      if (!isClosed) {
        emit(LandingImagesSuccess(landingImages));
      }
    } catch (e) {
      if (!isClosed) {
        emit(LandingImagesFetchError(e.toString()));
      }
    }
  }
}

score 2 · Answer 7 · answered Feb 05 '20 at 02:43

@cwhisperer is absolutely right. Initialize and dispose your block inside widget just like bellow.

final ServiceBloc serviceBloc = new ServiceBloc();

  @override
  void initState() {
    serviceBloc.getAllServices();
    super.initState();
  }

  @override
  void dispose() {
    serviceBloc.dispose();
    super.dispose();
  }

and delete ServiceBloc serviceBloc = new ServiceBloc(); from your class ServiceBloc

score 1 · Answer 8 · edited Nov 30 '20 at 06:50

1

ServiceBloc serviceBloc = new ServiceBloc();

// remove this code // don't init class in the same page that will cause of bad state.

edited Nov 30 '20 at 06:50

TuGordoBello

4,350
9
52
78

answered Aug 09 '20 at 07:08

reimi

179
2
4

score 1 · Answer 9 · answered Jan 31 '22 at 09:45

I also faced this issue in production, and I realized that we should either dispose BehaviorSubject (or any other StreamController) when the Widget is disposed or Check to see if Stream is closed before adding new value.

Here is a nice extension to do all the job:

extension BehaviorSubjectExtensions <T> on BehaviorSubject<T> {
  set safeValue(T newValue) => isClosed == false ? add(newValue) : () {};
}

You can use it like so:

class MyBloc {
  final _data = BehaviorSubject<String>();
  
  void fetchData() {
    // get your data from wherever it is located
    _data.safeValue = 'Safe to add data';
  }

  void dispose() {
    _data.close();
  }
}

How to dispose in Widget:

class CategoryPage extends StatefulWidget {
  @override
  _CategoryPageState createState() => _CategoryPageState();
}

class _CategoryPageState extends State<CategoryPage> {
  late MyBloc bloc;

  @override
  void initState() {
    bloc = MyBloc();
    bloc.fetchData();
    super.initState();
  }

  @override
  void dispose() {
    bloc.dispose();
    super.dispose();
  }

  // Other part of your Widget
}

score 0 · Answer 10 · answered Apr 02 '22 at 14:17

0

even better, if you aren't sure you won't reuse the stream after disposing:

call the drain() function on the stream before closing the stream.

dispose() async{
await _coinDataFetcher.drain();
_coinDataFetcher.close();
_isdisposed = true;

}

answered Apr 02 '22 at 14:17

Victor Chinyeaka

1
1

flutter: Unhandled Exception: Bad state: Cannot add new events after calling close

10 Answers10

Linked