Is it ok to exit a while loop like this when using input overload

Question

re updated my question and found this fix to exit a while loop when using an overloading input stream, is this ok to use?? i don't want to use it just because it works.

int main()
{
    cout << "start" << endl;

    Vector<WindLogType> windlog;

    fstream file("MetData.csv");

    while (!file.eof())
    {
        WindLogType temp;

        file >> temp;

        windlog.insert(temp);

        if (file.peek() != EOF) {
            break;
        }
    }

    }

    cout << "end" << endl;
}

Note that you pass the `WindLogType` object to your input operator by *value*. — Some programmer dude, Apr 08 '19 at 11:49
And unless it's part of your exercise or assignment, don't use your own `Vector` types, use the standard `std::vector`. — Some programmer dude, Apr 08 '19 at 11:50
yeah its meant to be this way, dynamic array, its in the question. — Getwrong, Apr 08 '19 at 11:50
Lastly, you don't need `typedef struct` in C++, all structure and class names are type-names. — Some programmer dude, Apr 08 '19 at 11:51

score 0 · Answer 1 · answered Apr 08 '19 at 11:46

0

Use break; when you "hit" the exit-criteria

answered Apr 08 '19 at 11:46

Alexander Falk

499
8
21

Is it ok to exit a while loop like this when using input overload

1 Answers1