Extracting substring between double qoutes in a XML tag

Question

I have been trying to get substrings in a XML tag. The string: "<Fruits Type="Apple" Quantity="10"></Fruits>",

I want only substring1 = Apple substring2 = 10.

string string1 ="<Fruits Type="Apple" Quantity="10"></Fruits>";
 int lPos = string1 .find("\"");
 string substring2 = string1.substr(lPos + 1);
 string substring1 = substring2.substr(0, substring2.find("\""));
 substring2 = substring2.substr(substring2.find("\""), substring2.rfind("\"")- substring2.find("\""));
 substring2 = substring2.substr(substring2.rfind("\"")+1);
 cout<<substring1 << "\n" << substring2;

The Thing is I'm able to get expected output. But what I want is to know if there is any efficient way other than this method.

When creating a [mcve], please make sure that it doesn't contain any unrelated errors, and that it really replicates the problem you have (and allow us to use the code to replicate the problem, with no or very little need for editing). — Some programmer dude, Apr 09 '19 at 07:56
Possible duplicate of https://stackoverflow.com/questions/27165227/read-xml-from-a-string-in-c-unix — Miller Cy Chan, Apr 09 '19 at 07:59
Are you using an xml library? https://github.com/fffaraz/awesome-cpp#xml — Fantastic Mr Fox, Apr 09 '19 at 08:12
@FantasticMrFox No im not using XML library.. Im just considering the tag as std::string — CodeKhaleesi, Apr 09 '19 at 12:31

score 0 · Accepted Answer · answered Apr 09 '19 at 08:31

Ok,

First of all there is no code provided by you, so there is no way what is wrong with it.

Second, in your string1 variable there is an error, it should be:

string string1 ="<Fruits Type=\"Apple\" Quantity=\"10\"></Fruits>";

or it will not compile.

Third, if you really want to search for strings like that, it can be done like this:

#include <iostream>
#include <string>

static std::string input = "<Fruits Type=\"Apple\" Quantity=\"10\"></Fruits>";

int main()
{
    std::string::size_type begin = input.find('\"');
    std::string::size_type end   = input.find('\"', ++begin);

    std::string buffer(input, begin, (end - begin));
    std::cout << buffer << std::endl;
    return 0;
}

Fourth and most important - please be kind to yourself and use some XML library to do it for you. You may face long, sleepless nights otherwise...

Extracting substring between double qoutes in a XML tag

1 Answers1